Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 821303002: Add a landmine to clobber broken GN bots. (Closed)

Created:
6 years ago by dcheng
Modified:
6 years ago
Reviewers:
eroman, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a landmine to clobber broken GN bots. GN bots are having trouble picking up the changes to the resouce ID range, which was changed in https://codereview.chromium.org/734243003/. BUG=444902 R=eroman@chromium.org, thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d1a85aee41655ad2c016ffe22320f0b1d9571e15

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/get_landmines.py View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 7 (1 generated)
dcheng
6 years ago (2014-12-23 22:45:06 UTC) #2
Nico
lgtm Lame that everyone needs to clobber just because gn doesn't get this right :-(
6 years ago (2014-12-23 22:48:35 UTC) #3
eroman
https://codereview.chromium.org/821303002/diff/1/build/get_landmines.py File build/get_landmines.py (right): https://codereview.chromium.org/821303002/diff/1/build/get_landmines.py#newcode66 build/get_landmines.py:66: print 'Clobber to fix GN not picking up increased ...
6 years ago (2014-12-23 22:51:43 UTC) #4
dcheng
https://codereview.chromium.org/821303002/diff/1/build/get_landmines.py File build/get_landmines.py (right): https://codereview.chromium.org/821303002/diff/1/build/get_landmines.py#newcode66 build/get_landmines.py:66: print 'Clobber to fix GN not picking up increased ...
6 years ago (2014-12-23 22:53:35 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d1a85aee41655ad2c016ffe22320f0b1d9571e15 Cr-Commit-Position: refs/heads/master@{#309588}
6 years ago (2014-12-23 22:55:50 UTC) #6
dcheng
6 years ago (2014-12-23 22:56:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1a85aee41655ad2c016ffe22320f0b1d9571e15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698