Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 821233003: Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (Closed)

Created:
5 years, 11 months ago by Shu Chen
Modified:
5 years, 11 months ago
Reviewers:
bshe, Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (patchset #1 id:1 of https://codereview.chromium.org/851333002/) Reason for revert: This cl caused regression that the backspace-to-decommit feature for both VK and physical keyboard autocorrect. Original issue's description: > Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText > > Previously, only text before cursor will be removed regardless the value of > offset. This CL adds support for deleting text after cursor. We want to this > feature in order to implement "set existing word to composition mode" feature > when cursor is moved inside an existing word. We want to be able to remove the > parts of the existing word before cursor and after cursor first and then call > setComposition to set the word to composition mode. > > Note: this API tries to comform the API spec of ibus delete_surrounding_text > here: ibus.googlecode.com/svn/docs/ibus-1.5/IBusInputContext.html#IBusInputContext-delete-surrounding-text > A noticible difference is a positive offset value in this API does not take effect. > > BUG=446249 > > Committed: https://crrev.com/756820cb2c42a7b302a16d24909d820ee18dad0e > Cr-Commit-Position: refs/heads/master@{#312113} TBR=nona@chromium.org,bshe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446249 Committed: https://crrev.com/7f17a7758881aa33e8790494b170962bc37e05d8 Cr-Commit-Position: refs/heads/master@{#312304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Shu Chen
Created Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText
5 years, 11 months ago (2015-01-21 00:47:43 UTC) #1
bshe
5 years, 11 months ago (2015-01-26 16:09:59 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/868663005/ by bshe@chromium.org.

The reason for reverting is: The regression is fixed in the extension code. It
should be safe to land this again..

Powered by Google App Engine
This is Rietveld 408576698