Source/core/layout/LayoutTableSection.h - Issue 821203003: Handling of percent less than 1 while extra height distribution in spanning rows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTableSection.h

Issue 821203003: Handling of percent less than 1 while extra height distribution in spanning rows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/table/table-rowspan-height-less-than-one-percent-expected.txt ('k') | Source/core/layout/LayoutTableSection.cpp » ('j') | Source/core/layout/LayoutTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutTableSection.h

diff --git a/Source/core/layout/LayoutTableSection.h b/Source/core/layout/LayoutTableSection.h

index 74034e185b53dfaee6a8381936e6835872b7f1bf..d7cb25c7fbe8e9803c5ba9e0a950ccb44446e563 100644

--- a/Source/core/layout/LayoutTableSection.h

+++ b/Source/core/layout/LayoutTableSection.h

@@ -260,8 +260,8 @@ private:

void updateRowsHeightHavingOnlySpanningCells(LayoutTableCell*, struct SpanningRowsHeight&, unsigned&, Vector<int>&);

void populateSpanningRowsHeightFromCell(LayoutTableCell*, struct SpanningRowsHeight&);

- void distributeExtraRowSpanHeightToPercentRows(LayoutTableCell*, int, int&, Vector<int>&);

- void distributeWholeExtraRowSpanHeightToPercentRows(LayoutTableCell*, int, int&, Vector<int>&);

+ void distributeExtraRowSpanHeightToPercentRows(LayoutTableCell*, LayoutUnit, int&, Vector<int>&);

+ void distributeWholeExtraRowSpanHeightToPercentRows(LayoutTableCell*, LayoutUnit, int&, Vector<int>&);

void distributeExtraRowSpanHeightToAutoRows(LayoutTableCell*, int, int&, Vector<int>&);

void distributeExtraRowSpanHeightToRemainingRows(LayoutTableCell*, int, int&, Vector<int>&);

void distributeRowSpanHeightToRows(SpanningLayoutTableCells& rowSpanCells);