LayoutTests/fast/table/table-rowspan-height-less-than-one-percent.html - Issue 821203003: Handling of percent less than 1 while extra height distribution in spanning rows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-rowspan-height-less-than-one-percent.html

Issue 821203003: Handling of percent less than 1 while extra height distribution in spanning rows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 th { height: .5%; }

	4 </style>

	5 <script type="text/javascript">

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8 </script>

	9 <body>

	10 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=408066">408066</a>. ASSERTION FAILED: !extraRowSpanningHeight in bl ink::RenderTableSection::distributeRowSpanHeightToRows.</h3>

	11 <p>For this test to PASS, it should not crash.</p>
	Julien - ping for review 2015/01/02 10:13:37 While it's OK to do a crash check, it's not really While it's OK to do a crash check, it's not really what you want. The ASSERT is a correctness issue and if it ASSERTs, it means that we don't compute the size correctly. That means it would be more interesting to do a check-layout.js test.
	12 <table>

	13 <th>

	14 <td rowspan="2">a</td>

	15 </th>

	16 </table>

	17 </body>

OLD	NEW