Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: Source/WebCore/bindings/v8/ScriptController.h

Issue 8212005: Merge 96991 - https://bugs.webkit.org/show_bug.cgi?id=69471 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/bindings/v8/NPV8Object.cpp ('k') | Source/WebCore/bindings/v8/ScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/bindings/v8/ScriptController.h
===================================================================
--- Source/WebCore/bindings/v8/ScriptController.h (revision 97018)
+++ Source/WebCore/bindings/v8/ScriptController.h (working copy)
@@ -208,7 +208,14 @@
// The frame keeps a NPObject reference for each item on the list.
PluginObjectMap m_pluginObjects;
#if ENABLE(NETSCAPE_PLUGIN_API)
- NPObject* m_windowScriptNPObject;
+ // The window script object can get destroyed while there are outstanding
+ // references to it. Please refer to ScriptController::clearScriptObjects
+ // for more information as to why this is necessary. To avoid crashes due
+ // to calls on the destroyed window object, we return a proxy NPObject
+ // which wraps the underlying window object. The wrapped window object
+ // pointer in this object is cleared out when the window object is
+ // destroyed.
+ NPObject* m_wrappedWindowScriptNPObject;
#endif
};
« no previous file with comments | « Source/WebCore/bindings/v8/NPV8Object.cpp ('k') | Source/WebCore/bindings/v8/ScriptController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698