Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 821173003: Fix Magic Mouse history swiping bug. (Closed)

Created:
5 years, 11 months ago by erikchen
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Magic Mouse history swiping bug. Magic Mouse gestures don't cause -touches*WithEvent: events to be sent down the responder chain. As such, all state related to Magic Mouse gestures needs to be reset during -beginGestureWithEvent:. BUG=317161 Committed: https://crrev.com/de515231c665422838bf93883a126b154d2e65ff Cr-Commit-Position: refs/heads/master@{#311762}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -3 lines) Patch
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h View 3 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm View 5 chunks +73 lines, -0 lines 2 comments Download

Messages

Total messages: 22 (9 generated)
erikchen
avi: Please review.
5 years, 11 months ago (2015-01-15 18:46:35 UTC) #4
Avi (use Gerrit)
lgtm
5 years, 11 months ago (2015-01-15 19:01:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821173003/40001
5 years, 11 months ago (2015-01-15 19:06:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/36316) Try jobs failed on following ...
5 years, 11 months ago (2015-01-15 19:14:46 UTC) #9
erikchen
thestig: Looking for an OWNER review.
5 years, 11 months ago (2015-01-15 19:17:14 UTC) #11
Lei Zhang
https://codereview.chromium.org/821173003/diff/40001/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm File chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm (right): https://codereview.chromium.org/821173003/diff/40001/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm#newcode497 chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm:497: // These tests require 10.7+ APIs. Don't the official ...
5 years, 11 months ago (2015-01-15 20:18:10 UTC) #12
erikchen
https://codereview.chromium.org/821173003/diff/40001/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm File chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm (right): https://codereview.chromium.org/821173003/diff/40001/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm#newcode497 chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm:497: // These tests require 10.7+ APIs. On 2015/01/15 20:18:10, ...
5 years, 11 months ago (2015-01-15 20:44:44 UTC) #13
Lei Zhang
Ok, lgtm stamp
5 years, 11 months ago (2015-01-15 21:49:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821173003/40001
5 years, 11 months ago (2015-01-15 22:17:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/36316)
5 years, 11 months ago (2015-01-15 22:52:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821173003/40001
5 years, 11 months ago (2015-01-15 22:58:28 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 11 months ago (2015-01-15 23:21:27 UTC) #21
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:22:29 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de515231c665422838bf93883a126b154d2e65ff
Cr-Commit-Position: refs/heads/master@{#311762}

Powered by Google App Engine
This is Rietveld 408576698