Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 821133006: ozone: Dispatch GPU process IPCs to IO thread directly from GpuPlatformSupportHost (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 11 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, darin-cc_chromium.org, jam, kalyank, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Dispatch GPU process IPCs to IO thread directly from GpuPlatformSupportHost This takes an (IO thread) TaskRunner & callback pair instead of an IPC::Sender when we establish the GPU channel, so that we'll be able to send messages to the GPU process from browser threads without passing through the UI thread. This is preparatory work to allow us to bypass the browser UI thread for cursor updates on freon builds. It doesn't change the code to send messages from other threads yet. BUG=446184 TEST=Boot link_freon to login screen Committed: https://crrev.com/d128d1293da9bf11aefcb335b4e94bdc9f85374d Cr-Commit-Position: refs/heads/master@{#310917}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -46 lines) Patch
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_gpu_platform_support_host.h View 3 chunks +11 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_gpu_platform_support_host.cc View 6 chunks +21 lines, -13 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/ozone/public/gpu_platform_support_host.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/ozone/public/gpu_platform_support_host.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/ozone/public/ui_thread_gpu.h View 2 chunks +4 lines, -7 lines 0 comments Download
M ui/ozone/public/ui_thread_gpu.cc View 3 chunks +65 lines, -18 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
spang
5 years, 11 months ago (2015-01-09 20:58:43 UTC) #2
alexst (slow to review)
lgtm https://codereview.chromium.org/821133006/diff/1/ui/ozone/public/ui_thread_gpu.cc File ui/ozone/public/ui_thread_gpu.cc (right): https://codereview.chromium.org/821133006/diff/1/ui/ozone/public/ui_thread_gpu.cc#newcode70 ui/ozone/public/ui_thread_gpu.cc:70: ->OnChannelEstablished(kGpuProcessHostId, task_runner_, sender); You call them send_runner and ...
5 years, 11 months ago (2015-01-09 21:53:08 UTC) #3
piman
lgtm
5 years, 11 months ago (2015-01-09 23:32:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821133006/1
5 years, 11 months ago (2015-01-10 00:05:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-10 00:35:31 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 00:36:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d128d1293da9bf11aefcb335b4e94bdc9f85374d
Cr-Commit-Position: refs/heads/master@{#310917}

Powered by Google App Engine
This is Rietveld 408576698