Issue 821123005: Move application_manager's ShellImpl to own file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 821123005: Move application_manager's ShellImpl to own file (Closed)

Created:
5 years, 11 months ago by jamesr

Modified:
5 years, 11 months ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move application_manager's ShellImpl to own file This class will need modifications for the Application/Shell client removal and it's awkward to modify it as an inner class in the cc file. This moves it to its own .h/.cc without changing any functionality. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f571318d3785f533acb7f2dd0f0e44f52d57903e

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -73 lines)			Patch
M	mojo/application_manager/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/application_manager/application_manager.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/application_manager/application_manager.cc	View	2 chunks	+0 lines, -69 lines	0 comments	Download
A	mojo/application_manager/shell_impl.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	mojo/application_manager/shell_impl.cc	View	1 chunk	+66 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

5 years, 11 months ago (2015-01-14 01:41:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f571318d3785f533acb7f2dd0f0e44f52d57903e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages