Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 821103003: Use gn check_targets and gn gen --check instead of presubmit (Closed)

Created:
5 years, 11 months ago by jamesr
Modified:
5 years, 11 months ago
Reviewers:
eseidel1, eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use gn check_targets and gn gen --check instead of presubmit gn has the ability to verify that 'gn check' passes for a set of targets during generation. Use this instead of a presubmit to avoid having to run gn multiple times and to get coverage on every run instead of just on presubmits. R=eseidel@google.com, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5f36d3794485583400bd8b8c38bc114ba367abae

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -59 lines) Patch
M .gn View 1 chunk +10 lines, -0 lines 1 comment Download
M PRESUBMIT.py View 2 chunks +0 lines, -58 lines 0 comments Download
M mojo/tools/mojob.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
5 years, 11 months ago (2015-01-08 18:47:35 UTC) #1
eseidel1
lgtm Does everythign pass gn check now? I don't see how your new code filters ...
5 years, 11 months ago (2015-01-08 19:10:46 UTC) #3
jamesr
https://codereview.chromium.org/821103003/diff/1/.gn File .gn (right): https://codereview.chromium.org/821103003/diff/1/.gn#newcode14 .gn:14: check_targets = [ this code filters
5 years, 11 months ago (2015-01-08 19:14:25 UTC) #4
jamesr
5 years, 11 months ago (2015-01-08 21:04:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f36d3794485583400bd8b8c38bc114ba367abae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698