Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 821093008: Merge 187602 "ScopedStyleResolver should be cleared when ShadowR..." (Closed)

Created:
6 years ago by kochi
Modified:
6 years ago
Reviewers:
tasak
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Project:
blink
Visibility:
Public.

Description

Merge 187602 "ScopedStyleResolver should be cleared when ShadowR..." > ScopedStyleResolver should be cleared when ShadowRoot is removed from document. > > If a shadow root (=treescope), which has a style element, is moved from a document to another document, a new ShadowStyleSheetCollection is created for the shadow root. > > The ShadowStyleSheetCollection has no active stylesheets, but the treescope's scopedStyleResolver has an active stylesheet. > > The active stylesheet has been already cleared (i.e. clearOwnerNode is invoked) while moving. > However, StyleEngine cannot clear the treescope's resolver, because the ShadowStyleSheetCollection has no information. This causes heap-use-after-free. > > BUG=443017 > TEST=fast/html/marquee-clone-crash.html > > Review URL: https://codereview.chromium.org/809343002 TBR=tasak@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
A + LayoutTests/fast/html/marquee-clone-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/marquee-clone-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/resources/marquee-crash.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kochi
6 years ago (2014-12-24 02:01:56 UTC) #1
kochi
6 years ago (2014-12-24 02:02:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r187669 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698