Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 821093006: Disable failing EncryptedMediaTest tests. (Closed)

Created:
5 years, 12 months ago by dgozman
Modified:
5 years, 12 months ago
Reviewers:
eroman
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable failing EncryptedMediaTest tests. BUG=444827 TBR=eroman NOTRY=true Committed: https://crrev.com/4353cae33756fd2fa4fd5384c9945943280345c7 Cr-Commit-Position: refs/heads/master@{#309554}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 2 chunks +19 lines, -1 line 1 comment Download

Messages

Total messages: 9 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821093006/1
5 years, 12 months ago (2014-12-23 12:31:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-23 12:32:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4353cae33756fd2fa4fd5384c9945943280345c7 Cr-Commit-Position: refs/heads/master@{#309554}
5 years, 12 months ago (2014-12-23 12:33:10 UTC) #4
Avi (use Gerrit)
:( The tree was closed; when it re-opened I was going to start reverting changes ...
5 years, 12 months ago (2014-12-23 17:44:44 UTC) #5
eroman
LGTM. Although not sure I understand avi's comment
5 years, 12 months ago (2014-12-23 18:15:06 UTC) #6
eroman
https://codereview.chromium.org/821093006/diff/1/chrome/browser/media/encrypted_media_browsertest.cc File chrome/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/821093006/diff/1/chrome/browser/media/encrypted_media_browsertest.cc#newcode560 chrome/browser/media/encrypted_media_browsertest.cc:560: IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, Playback_VP9Video_WebM) { Actually, the test name here needs ...
5 years, 12 months ago (2014-12-23 18:32:24 UTC) #7
Avi (use Gerrit)
On 2014/12/23 18:15:06, eroman wrote: > LGTM. > > Although not sure I understand avi's ...
5 years, 12 months ago (2014-12-23 21:24:17 UTC) #8
Avi (use Gerrit)
5 years, 12 months ago (2014-12-23 21:24:32 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/823023002/ by avi@chromium.org.

The reason for reverting is: I reverted the guilty commit; re-enabling the
tests..

Powered by Google App Engine
This is Rietveld 408576698