Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 821063002: Move DocumentTabModelSelector and related classes upstream (Closed)

Created:
6 years ago by gone
Modified:
6 years ago
Reviewers:
cjhopman, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DocumentTabModelSelector and related classes upstream * Moves various classes upstream. * Changes ActivityDelegate to use the DocumentUtils to access the task's baseIntent instead of calling getTaskInfo() directly. * Findbugs file changed for fields that are only read downstream. Submitting with NOTRY as true to get around findbugs submission issues. BUG=443773 NOTRY=true Committed: https://crrev.com/df1702e8aa43e3996d64c0988e48612a5fad4624 Cr-Commit-Position: refs/heads/master@{#309473}

Patch Set 1 #

Patch Set 2 : Findbugs adjustment #

Patch Set 3 : Rearranging functions #

Messages

Total messages: 19 (8 generated)
gone
6 years ago (2014-12-22 20:07:30 UTC) #2
Yusuf
lgtm
6 years ago (2014-12-22 21:36:38 UTC) #3
gone
TBR cjhopman for the findbugs change.
6 years ago (2014-12-22 21:57:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821063002/20001
6 years ago (2014-12-22 21:58:34 UTC) #8
cjhopman
lgtm
6 years ago (2014-12-22 22:03:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/32037)
6 years ago (2014-12-22 22:05:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821063002/40001
6 years ago (2014-12-22 22:12:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/32046)
6 years ago (2014-12-22 22:20:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821063002/40001
6 years ago (2014-12-22 22:36:48 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-22 22:38:30 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-22 22:40:15 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/df1702e8aa43e3996d64c0988e48612a5fad4624
Cr-Commit-Position: refs/heads/master@{#309473}

Powered by Google App Engine
This is Rietveld 408576698