Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 821033002: Tweak tracing JSON output formatting. (Closed)

Created:
6 years ago by alph
Modified:
5 years, 11 months ago
Reviewers:
dsinclair, nduca, yurys
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak tracing JSON output formatting. - \n between events - move category field past ones having a fixed width. Committed: https://crrev.com/4feef6baa415f8616ad2f93041e3437899996d4b Cr-Commit-Position: refs/heads/master@{#311301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/debug/trace_event_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
alph
6 years ago (2014-12-22 13:59:06 UTC) #2
yurys
lgtm
6 years ago (2014-12-22 15:23:34 UTC) #3
dsinclair
Is there a reason to do this, or is it to just make the output ...
5 years, 11 months ago (2015-01-05 14:59:24 UTC) #4
yurys
On 2015/01/05 14:59:24, dsinclair wrote: > Is there a reason to do this, or is ...
5 years, 11 months ago (2015-01-13 10:19:49 UTC) #5
alph
On 2015/01/13 10:19:49, yurys wrote: > On 2015/01/05 14:59:24, dsinclair wrote: > > Is there ...
5 years, 11 months ago (2015-01-13 10:30:29 UTC) #6
dsinclair
On 2015/01/13 at 10:30:29, alph wrote: > On 2015/01/13 10:19:49, yurys wrote: > > On ...
5 years, 11 months ago (2015-01-13 14:18:48 UTC) #7
dsinclair
5 years, 11 months ago (2015-01-13 14:18:59 UTC) #9
alph
On 2015/01/13 14:18:48, dsinclair wrote: > On 2015/01/13 at 10:30:29, alph wrote: > > On ...
5 years, 11 months ago (2015-01-13 14:23:29 UTC) #10
dsinclair
lgtm
5 years, 11 months ago (2015-01-13 17:45:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821033002/1
5 years, 11 months ago (2015-01-13 17:45:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 19:01:01 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 19:02:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4feef6baa415f8616ad2f93041e3437899996d4b
Cr-Commit-Position: refs/heads/master@{#311301}

Powered by Google App Engine
This is Rietveld 408576698