Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Issue 821023005: Update createChildFrame in mojo's html_viewer to take sandbox flags (Closed)

Created:
5 years, 11 months ago by alexmos
Modified:
5 years, 11 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update createChildFrame in mojo's html_viewer to take sandbox flags. WebFrameClient::createChildFrame is being updated to take sandbox flags in https://codereview.chromium.org/838903002/, with the goal of replicating them for out-of-process iframes. This needs to be updated to the new version as well. BUG=426512 Committed: https://crrev.com/c098f9c489b5b7976834ae538d8b9f0d446a7da5 Cr-Commit-Position: refs/heads/master@{#312296}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Include WebSandboxFlags.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M mojo/services/html_viewer/html_document.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alexmos
aa@: could you please review this small CL? I missed this when doing similar refactoring ...
5 years, 11 months ago (2015-01-16 21:38:50 UTC) #2
Aaron Boodman
lgtm
5 years, 11 months ago (2015-01-20 19:47:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821023005/40001
5 years, 11 months ago (2015-01-20 22:15:43 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-20 23:07:11 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 23:08:03 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c098f9c489b5b7976834ae538d8b9f0d446a7da5
Cr-Commit-Position: refs/heads/master@{#312296}

Powered by Google App Engine
This is Rietveld 408576698