Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 821013002: Stop demo mode detection correctly. (Closed)

Created:
6 years ago by dzhioev (left Google)
Modified:
6 years ago
Reviewers:
merkulova
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop demo mode detection correctly. |oobe_timer_| kept running after StopDetection() call. So in fact demo mode detection remained active. BUG=439956 TEST=Run 'chromeos=1' debug build with options --derelict-detection-timeout=10 --derelict-idle-timeout=10 --oobe-timer-interval=10. Enroll into enterprise domain, wait for 10 seconds at "Your device has successfully been enrolled." screen. Nothing should happen. Committed: https://crrev.com/8ac4d6f3f2dd65f4a06d5bcd6c4976d0bb0bb1de Cr-Commit-Position: refs/heads/master@{#309418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/demo_mode_detector.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dzhioev (left Google)
6 years ago (2014-12-22 11:28:07 UTC) #2
merkulova
lgtm
6 years ago (2014-12-22 11:42:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821013002/1
6 years ago (2014-12-22 12:46:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 13:44:02 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-22 13:44:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ac4d6f3f2dd65f4a06d5bcd6c4976d0bb0bb1de
Cr-Commit-Position: refs/heads/master@{#309418}

Powered by Google App Engine
This is Rietveld 408576698