Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 821003002: Files.app: Fix TaskController so that it calls correct default task. (Closed)

Created:
6 years ago by hirono
Modified:
5 years, 12 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix TaskController so that it calls correct default task. Previously the TaskController calls the private version of executeDefaultTask method that does not wait for initialization completion of FileTasks. Thus it tries to call default task before the default task is determined. BUG=443942 TEST=manually Committed: https://crrev.com/697b5dc34dfe7c4cf4e11e71b79e18cefaf7282b Cr-Commit-Position: refs/heads/master@{#309616}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : Add Licence #

Messages

Total messages: 13 (4 generated)
hirono
PTAL? Thanks!
5 years, 12 months ago (2014-12-24 01:36:11 UTC) #2
yawano
https://codereview.chromium.org/821003002/diff/40001/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js File ui/file_manager/file_manager/foreground/js/task_controller_unittest.js (right): https://codereview.chromium.org/821003002/diff/40001/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js#newcode7 ui/file_manager/file_manager/foreground/js/task_controller_unittest.js:7: ]), 100); Please change time to 0 if the ...
5 years, 12 months ago (2014-12-24 02:31:44 UTC) #3
hirono
Thanks! https://codereview.chromium.org/821003002/diff/40001/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js File ui/file_manager/file_manager/foreground/js/task_controller_unittest.js (right): https://codereview.chromium.org/821003002/diff/40001/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js#newcode7 ui/file_manager/file_manager/foreground/js/task_controller_unittest.js:7: ]), 100); On 2014/12/24 02:31:44, yawano wrote: > ...
5 years, 12 months ago (2014-12-24 02:39:11 UTC) #4
yawano
lgtm. Thank you.
5 years, 12 months ago (2014-12-24 02:40:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821003002/60001
5 years, 12 months ago (2014-12-24 03:34:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/32265)
5 years, 12 months ago (2014-12-24 03:40:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821003002/80001
5 years, 12 months ago (2014-12-24 03:44:07 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 12 months ago (2014-12-24 04:38:31 UTC) #12
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 04:39:53 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/697b5dc34dfe7c4cf4e11e71b79e18cefaf7282b
Cr-Commit-Position: refs/heads/master@{#309616}

Powered by Google App Engine
This is Rietveld 408576698