Issue 820993002: [turbofan] Materialize the correct kind of constant for bit 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 820993002: [turbofan] Materialize the correct kind of constant for bit 1. (Closed)

Created:
6 years ago by Benedikt Meurer

Modified:
6 years ago

Reviewers:
Hannes Payer (out of office), jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Materialize the correct kind of constant for bit 1. Bit 1 should be represented as Int32Constant 1 after simplified lowering, but OneConstant returns NumberConstant 1.0. R=jochen@chromium.org, hpayer@chromium.org Committed: https://crrev.com/c61abc14264f0232a53a721512ec8646de574f16 Cr-Commit-Position: refs/heads/master@{#25919}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/compiler/representation-change.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/c61abc14264f0232a53a721512ec8646de574f16 Cr-Commit-Position: refs/heads/master@{#25919}

6 years ago (2014-12-22 09:24:27 UTC) #5

Benedikt Meurer

6 years ago (2014-12-22 09:24:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c61abc14264f0232a53a721512ec8646de574f16 (presubmit successful).