Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 820963002: X87: fix one test case failure under debug mode. (Closed)

Created:
6 years ago by chunyang.dai
Modified:
6 years ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: fix one test case failure under debug mode. This issue is exposed by CL https://codereview.chromium.org/807273003. The DeoptimizeIf(...) function will generate more Assembler code and the distance between the link point and the bind point is larger then near link distance (127) for labels. BUG= Committed: https://crrev.com/b4302150b18d135f0810934cc5944d298db13b13 Cr-Commit-Position: refs/heads/master@{#25914}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
WL. PTAL. thanks
6 years ago (2014-12-22 02:27:41 UTC) #2
Weiliang
lgtm
6 years ago (2014-12-22 06:36:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820963002/20001
6 years ago (2014-12-22 06:37:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-22 07:04:43 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-22 07:04:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4302150b18d135f0810934cc5944d298db13b13
Cr-Commit-Position: refs/heads/master@{#25914}

Powered by Google App Engine
This is Rietveld 408576698