Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 820943003: Revert of Fix crash after Launcher drag/drop (take 2) (Closed)

Created:
6 years ago by benwells
Modified:
6 years ago
Reviewers:
Greg Levin, jennyz
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix crash after Launcher drag/drop (take 2) (patchset #1 id:1 of https://codereview.chromium.org/792883006/) Reason for revert: The new test is still causing problems. See http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/44030. The test appears to be flaky. It has failed on that bot on 4 of the 6 runs since this change landed. BTW I'd add calamity@ to any reviews of dragging in the launcher as he has fixed many bugs there and is aware of many subtleties in the code. Original issue's description: > Fix crash after Launcher drag/drop (take 2) > > BUG=439055 > TEST=In Launcher, drag app to solitary folder on second page > > This is a retry of https://codereview.chromium.org/780023002/ , > which was reverted after commit due to a failed valgrind test. > > Committed: https://crrev.com/62e30ca368387d4edbbbf5c721f30881586b2387 > Cr-Commit-Position: refs/heads/master@{#309235} TBR=jennyz@chromium.org,glevin@chromium.org NOTREECHECKS=true NOTRY=true BUG=439055 Committed: https://crrev.com/0322e831140263f648d2090763a0d24277f9ade5 Cr-Commit-Position: refs/heads/master@{#309386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -84 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 3 chunks +9 lines, -71 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Created Revert of Fix crash after Launcher drag/drop (take 2)
6 years ago (2014-12-22 02:52:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820943003/1
6 years ago (2014-12-22 02:53:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 02:53:48 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-22 02:54:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0322e831140263f648d2090763a0d24277f9ade5
Cr-Commit-Position: refs/heads/master@{#309386}

Powered by Google App Engine
This is Rietveld 408576698