Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 820843002: Flush the pending input ack when the RenderWidget is hidden (Closed)

Created:
6 years ago by jdduke (slow)
Modified:
6 years ago
Reviewers:
piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flush the pending input ack when the RenderWidget is hidden A throttled ack will be held until the commit, which may not happen if the widget is hidden. Flush the ack when widget visibility changes, ensuring the browser process gets a timely ack. BUG=436379 Committed: https://crrev.com/8fac9d101f18be0e719477e27efb54cbde826546 Cr-Commit-Position: refs/heads/master@{#309324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/render_widget.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jdduke (slow)
piman@: PTAL. This may not be the right fix, but I'd like to get it ...
6 years ago (2014-12-20 01:49:38 UTC) #2
jdduke (slow)
piman@: PTAL. This may not be the right fix, but I'd like to get it ...
6 years ago (2014-12-20 01:49:39 UTC) #3
piman
lgtm
6 years ago (2014-12-20 01:49:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820843002/1
6 years ago (2014-12-20 01:51:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-20 02:40:40 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-20 02:41:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fac9d101f18be0e719477e27efb54cbde826546
Cr-Commit-Position: refs/heads/master@{#309324}

Powered by Google App Engine
This is Rietveld 408576698