Source/core/css/resolver/StyleBuilderConverter.h - Issue 82083002: Move viewport unit resolution to style recalc time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 82083002: Move viewport unit resolution to style recalc time (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: rebased.. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleBuilderConverter.h

diff --git a/Source/core/css/resolver/StyleBuilderConverter.h b/Source/core/css/resolver/StyleBuilderConverter.h

index 12f03ecfdccffe79bfe2f812202257806d006e92..0a337c81cb57472ae11285f00a5f71de210ae371 100644

--- a/Source/core/css/resolver/StyleBuilderConverter.h

+++ b/Source/core/css/resolver/StyleBuilderConverter.h

@@ -73,8 +73,6 @@ T StyleBuilderConverter::convertLineWidth(StyleResolverState& state, CSSValue* v

return 3;

if (valueID == CSSValueThick)

return 5;

- if (primitiveValue->isViewportPercentageLength())

- return intValueForLength(primitiveValue->viewportPercentageLength(), 0, state.document().renderView());

if (valueID == CSSValueInvalid) {

// Any original result that was >= 1 should not be allowed to fall below 1.

// This keeps border lines from vanishing.