Chromium Code Reviews Chromium Code Reviews
Issue 82083002:
Move viewport unit resolution to style recalc time (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink@master| Index: LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt |
| diff --git a/LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt b/LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt |
| index fc77fcb43f5e72151780f8bdcc5362fa3a51416a..450c823805155259182783347cff1ea652bb2e50 100644 |
| --- a/LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt |
| +++ b/LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt |
| @@ -8,19 +8,19 @@ PASS style.getPropertyValue("height") is '240px' |
| PASS style.getPropertyValue("width") is '240px' |
| PASS style.getPropertyValue("font-size") is '24px' |
| PASS style.getPropertyValue("line-height") is '32px' |
| -PASS style.getPropertyValue("text-indent") is '2vw' |
| +PASS style.getPropertyValue("text-indent") is '16px' |
| PASS style.getPropertyValue("margin-left") is '16px' |
| PASS style.getPropertyValue("margin-right") is '16px' |
| PASS style.getPropertyValue("margin-top") is '16px' |
| PASS style.getPropertyValue("margin-bottom") is '16px' |
| -PASS style.getPropertyValue("border-top-left-radius") is '1vw' |
| -PASS style.getPropertyValue("border-top-right-radius") is '1vw' |
| -PASS style.getPropertyValue("border-bottom-left-radius") is '1vw' |
| -PASS style.getPropertyValue("border-bottom-right-radius") is '1vw' |
| -PASS style.getPropertyValue("min-height") is '10vw' |
| -PASS style.getPropertyValue("min-width") is '10vw' |
| -PASS style.getPropertyValue("max-height") is '60vw' |
| -PASS style.getPropertyValue("max-width") is '60vw' |
| +PASS style.getPropertyValue("border-top-left-radius") is '8px' |
| +PASS style.getPropertyValue("border-top-right-radius") is '8px' |
| +PASS style.getPropertyValue("border-bottom-left-radius") is '8px' |
| +PASS style.getPropertyValue("border-bottom-right-radius") is '8px' |
| +PASS style.getPropertyValue("min-height") is '80px' |
| +PASS style.getPropertyValue("min-width") is '80px' |
| +PASS style.getPropertyValue("max-height") is '480px' |
| +PASS style.getPropertyValue("max-width") is '480px' |
| PASS style.getPropertyValue("top") is '80px' |
| PASS style.getPropertyValue("bottom") is '80px' |
| PASS style.getPropertyValue("left") is '80px' |
| @@ -35,19 +35,19 @@ PASS style.getPropertyValue("height") is '180px' |
| PASS style.getPropertyValue("width") is '180px' |
| PASS style.getPropertyValue("font-size") is '18px' |
| PASS style.getPropertyValue("line-height") is '24px' |
| -PASS style.getPropertyValue("text-indent") is '2vh' |
| +PASS style.getPropertyValue("text-indent") is '12px' |
| PASS style.getPropertyValue("margin-left") is '12px' |
| PASS style.getPropertyValue("margin-right") is '12px' |
| PASS style.getPropertyValue("margin-top") is '12px' |
| PASS style.getPropertyValue("margin-bottom") is '12px' |
| -PASS style.getPropertyValue("border-top-left-radius") is '1vh' |
| -PASS style.getPropertyValue("border-top-right-radius") is '1vh' |
| -PASS style.getPropertyValue("border-bottom-left-radius") is '1vh' |
| -PASS style.getPropertyValue("border-bottom-right-radius") is '1vh' |
| -PASS style.getPropertyValue("min-height") is '10vh' |
| -PASS style.getPropertyValue("min-width") is '10vh' |
| -PASS style.getPropertyValue("max-height") is '60vh' |
| -PASS style.getPropertyValue("max-width") is '60vh' |
| +PASS style.getPropertyValue("border-top-left-radius") is '6px' |
| +PASS style.getPropertyValue("border-top-right-radius") is '6px' |
| +PASS style.getPropertyValue("border-bottom-left-radius") is '6px' |
|
esprehn
2013/12/04 06:02:28
This seems we changed web exposed behavior, but gi
Timothy Loh
2013/12/04 07:17:39
Firefox behaves the same as our new behaviour. Mad
|
| +PASS style.getPropertyValue("border-bottom-right-radius") is '6px' |
| +PASS style.getPropertyValue("min-height") is '60px' |
| +PASS style.getPropertyValue("min-width") is '60px' |
| +PASS style.getPropertyValue("max-height") is '360px' |
| +PASS style.getPropertyValue("max-width") is '360px' |
| PASS style.getPropertyValue("top") is '60px' |
| PASS style.getPropertyValue("bottom") is '60px' |
| PASS style.getPropertyValue("left") is '60px' |
| @@ -62,19 +62,19 @@ PASS style.getPropertyValue("height") is '180px' |
| PASS style.getPropertyValue("width") is '180px' |
| PASS style.getPropertyValue("font-size") is '18px' |
| PASS style.getPropertyValue("line-height") is '24px' |
| -PASS style.getPropertyValue("text-indent") is '2vmin' |
| +PASS style.getPropertyValue("text-indent") is '12px' |
| PASS style.getPropertyValue("margin-left") is '12px' |
| PASS style.getPropertyValue("margin-right") is '12px' |
| PASS style.getPropertyValue("margin-top") is '12px' |
| PASS style.getPropertyValue("margin-bottom") is '12px' |
| -PASS style.getPropertyValue("border-top-left-radius") is '1vmin' |
| -PASS style.getPropertyValue("border-top-right-radius") is '1vmin' |
| -PASS style.getPropertyValue("border-bottom-left-radius") is '1vmin' |
| -PASS style.getPropertyValue("border-bottom-right-radius") is '1vmin' |
| -PASS style.getPropertyValue("min-height") is '10vmin' |
| -PASS style.getPropertyValue("min-width") is '10vmin' |
| -PASS style.getPropertyValue("max-height") is '60vmin' |
| -PASS style.getPropertyValue("max-width") is '60vmin' |
| +PASS style.getPropertyValue("border-top-left-radius") is '6px' |
| +PASS style.getPropertyValue("border-top-right-radius") is '6px' |
| +PASS style.getPropertyValue("border-bottom-left-radius") is '6px' |
| +PASS style.getPropertyValue("border-bottom-right-radius") is '6px' |
| +PASS style.getPropertyValue("min-height") is '60px' |
| +PASS style.getPropertyValue("min-width") is '60px' |
| +PASS style.getPropertyValue("max-height") is '360px' |
| +PASS style.getPropertyValue("max-width") is '360px' |
| PASS style.getPropertyValue("top") is '60px' |
| PASS style.getPropertyValue("bottom") is '60px' |
| PASS style.getPropertyValue("left") is '60px' |
| @@ -89,19 +89,19 @@ PASS style.getPropertyValue("height") is '240px' |
| PASS style.getPropertyValue("width") is '240px' |
| PASS style.getPropertyValue("font-size") is '24px' |
| PASS style.getPropertyValue("line-height") is '32px' |
| -PASS style.getPropertyValue("text-indent") is '2vmax' |
| +PASS style.getPropertyValue("text-indent") is '16px' |
| PASS style.getPropertyValue("margin-left") is '16px' |
| PASS style.getPropertyValue("margin-right") is '16px' |
| PASS style.getPropertyValue("margin-top") is '16px' |
| PASS style.getPropertyValue("margin-bottom") is '16px' |
| -PASS style.getPropertyValue("border-top-left-radius") is '1vmax' |
| -PASS style.getPropertyValue("border-top-right-radius") is '1vmax' |
| -PASS style.getPropertyValue("border-bottom-left-radius") is '1vmax' |
| -PASS style.getPropertyValue("border-bottom-right-radius") is '1vmax' |
| -PASS style.getPropertyValue("min-height") is '10vmax' |
| -PASS style.getPropertyValue("min-width") is '10vmax' |
| -PASS style.getPropertyValue("max-height") is '60vmax' |
| -PASS style.getPropertyValue("max-width") is '60vmax' |
| +PASS style.getPropertyValue("border-top-left-radius") is '8px' |
| +PASS style.getPropertyValue("border-top-right-radius") is '8px' |
| +PASS style.getPropertyValue("border-bottom-left-radius") is '8px' |
| +PASS style.getPropertyValue("border-bottom-right-radius") is '8px' |
| +PASS style.getPropertyValue("min-height") is '80px' |
| +PASS style.getPropertyValue("min-width") is '80px' |
| +PASS style.getPropertyValue("max-height") is '480px' |
| +PASS style.getPropertyValue("max-width") is '480px' |
| PASS style.getPropertyValue("top") is '80px' |
| PASS style.getPropertyValue("bottom") is '80px' |
| PASS style.getPropertyValue("left") is '80px' |
