Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 82083002: Move viewport unit resolution to style recalc time (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: rename browser zoom to page zoom Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/StyleResolver.h ('k') | Source/core/css/resolver/StyleResolverState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/StyleResolver.cpp
diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp
index 9361ae52be06d22dcdd73fc8388fd466dd0ff1cd..25645048338e5cf8e3cf7308e919cdf7b334abf2 100644
--- a/Source/core/css/resolver/StyleResolver.cpp
+++ b/Source/core/css/resolver/StyleResolver.cpp
@@ -731,6 +731,9 @@ PassRefPtr<RenderStyle> StyleResolver::styleForElement(Element* element, RenderS
setAnimationUpdateIfNeeded(state, *element);
+ if (state.style()->hasViewportUnits())
+ document().setHasViewportUnits();
+
// Now return the style.
return state.takeStyle();
}
@@ -940,6 +943,9 @@ PassRefPtr<RenderStyle> StyleResolver::pseudoStyleForElement(Element* element, c
if (PseudoElement* pseudoElement = element->pseudoElement(pseudoStyleRequest.pseudoId))
setAnimationUpdateIfNeeded(state, *pseudoElement);
+ if (state.style()->hasViewportUnits())
+ document().setHasViewportUnits();
+
// Now return the style.
return state.takeStyle();
}
@@ -1045,6 +1051,8 @@ bool StyleResolver::checkRegionStyle(Element* regionElement)
void StyleResolver::updateFont(StyleResolverState& state)
{
state.fontBuilder().createFont(document().styleEngine()->fontSelector(), state.parentStyle(), state.style());
+ if (state.fontBuilder().fontSizeHasViewportUnits())
+ state.style()->setHasViewportUnits();
}
PassRefPtr<StyleRuleList> StyleResolver::styleRulesForElement(Element* element, unsigned rulesToInclude)
@@ -1293,6 +1301,12 @@ void StyleResolver::invalidateMatchedPropertiesCache()
m_matchedPropertiesCache.clear();
}
+void StyleResolver::notifyResizeForViewportUnits()
+{
+ collectViewportRules();
+ m_matchedPropertiesCache.clearViewportDependent();
+}
+
void StyleResolver::applyMatchedProperties(StyleResolverState& state, const MatchResult& matchResult)
{
const Element* element = state.element();
@@ -1458,7 +1472,7 @@ void StyleResolver::addMediaQueryResults(const MediaQueryResultList& list)
m_viewportDependentMediaQueryResults.append(list[i]);
}
-bool StyleResolver::affectedByViewportChange() const
+bool StyleResolver::mediaQueryAffectedByViewportChange() const
{
for (unsigned i = 0; i < m_viewportDependentMediaQueryResults.size(); ++i) {
if (m_medium->eval(&m_viewportDependentMediaQueryResults[i]->m_expression) != m_viewportDependentMediaQueryResults[i]->m_result)
« no previous file with comments | « Source/core/css/resolver/StyleResolver.h ('k') | Source/core/css/resolver/StyleResolverState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698