Source/core/rendering/RootInlineBox.cpp - Issue 82083002: Move viewport unit resolution to style recalc time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RootInlineBox.cpp

Issue 82083002: Move viewport unit resolution to style recalc time (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RootInlineBox.cpp

diff --git a/Source/core/rendering/RootInlineBox.cpp b/Source/core/rendering/RootInlineBox.cpp

index 33cf9ad71387a09b1077c5151102aae926f2110e..3b4be53111a42398a5aec6d5f719f3f6e0dec18a 100644

--- a/Source/core/rendering/RootInlineBox.cpp

+++ b/Source/core/rendering/RootInlineBox.cpp

@@ -891,7 +891,7 @@ LayoutUnit RootInlineBox::verticalPositionForBox(InlineBox* box, VerticalPositio

lineHeight = renderer->style()->computedLineHeight();

else

lineHeight = renderer->lineHeight(firstLine, lineDirection);

- verticalPosition -= valueForLength(renderer->style()->verticalAlignLength(), lineHeight, renderer->view());

+ verticalPosition -= valueForLength(renderer->style()->verticalAlignLength(), lineHeight);

}