Source/core/rendering/RenderMenuList.cpp - Issue 82083002: Move viewport unit resolution to style recalc time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMenuList.cpp

Issue 82083002: Move viewport unit resolution to style recalc time (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: actually fix zoom handling Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderMenuList.cpp

diff --git a/Source/core/rendering/RenderMenuList.cpp b/Source/core/rendering/RenderMenuList.cpp

index 57c8afc1cf839a63591bb167227846c369c2c6ad..02f35713834c8dd4f2a2cde3db0a45f5459464af 100644

--- a/Source/core/rendering/RenderMenuList.cpp

+++ b/Source/core/rendering/RenderMenuList.cpp

@@ -175,7 +175,7 @@ void RenderMenuList::updateOptionsWidth()

// Add in the option's text indent. We can't calculate percentage values for now.

float optionWidth = 0;

if (RenderStyle* optionStyle = element->renderStyle())

- optionWidth += minimumValueForLength(optionStyle->textIndent(), 0, view());

+ optionWidth += minimumValueForLength(optionStyle->textIndent(), 0);

if (!text.isEmpty())

optionWidth += style()->font().width(text);

maxOptionWidth = max(maxOptionWidth, optionWidth);