Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: Source/platform/LengthFunctions.cpp

Issue 82083002: Move viewport unit resolution to style recalc time (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: rebased Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/LengthFunctions.cpp
diff --git a/Source/platform/LengthFunctions.cpp b/Source/platform/LengthFunctions.cpp
index b1b72fafb99abffe7a4244110a00e3306b9d53a5..d6af4604bc712e799d1f9370cdfc388dbd61bc44 100644
--- a/Source/platform/LengthFunctions.cpp
+++ b/Source/platform/LengthFunctions.cpp
@@ -43,17 +43,14 @@ float floatValueForLength(const Length& length, float maximumValue)
return static_cast<float>(maximumValue);
case Calculated:
return length.nonNanCalculatedValue(maximumValue);
- case ViewportPercentageWidth:
kenneth.r.christiansen 2013/12/16 10:08:19 Ain't you breaking @viewport { width: 100%; } when
Timothy Loh 2013/12/18 07:18:27 You probably mean 100vw here; this works because w
- case ViewportPercentageHeight:
- case ViewportPercentageMin:
- case ViewportPercentageMax:
- return 0;
case Intrinsic:
case MinIntrinsic:
case MinContent:
case MaxContent:
case FitContent:
case ExtendToZoom:
+ case DeviceWidth:
+ case DeviceHeight:
case Undefined:
ASSERT_NOT_REACHED();
return 0;

Powered by Google App Engine
This is Rietveld 408576698