Source/core/css/CSSPrimitiveValueMappings.h - Issue 82083002: Move viewport unit resolution to style recalc time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValueMappings.h

Issue 82083002: Move viewport unit resolution to style recalc time (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: rebased Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSPrimitiveValueMappings.h

diff --git a/Source/core/css/CSSPrimitiveValueMappings.h b/Source/core/css/CSSPrimitiveValueMappings.h

index 4b5b0a4c8493ad9548173f1ff8e6c1a91db761cc..17a7b9b5fd25e286267960047bbe307a88cd2eaa 100644

--- a/Source/core/css/CSSPrimitiveValueMappings.h

+++ b/Source/core/css/CSSPrimitiveValueMappings.h

@@ -4452,8 +4452,6 @@ template<int supported> Length CSSPrimitiveValue::convertToLength(const CSSToLen

return Length(Auto);

if ((supported & FixedConversion) && (supported & PercentConversion) && isCalculated())

return Length(cssCalcValue()->toCalcValue(conversionData));

- if ((supported & FixedConversion) && isViewportPercentageLength())

- return viewportPercentageLength();

return Length(Undefined);

}