Add UUID::InitializeFromString().

Add UUID::InitializeFromString().

R=mark@chromium.org
TEST=util_test --gtest_filter=UUID.FromString

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c75dc46b17d24735920a44f42e3981069e6f018a

[Mark Mentovai, 2015-01-02 23:33:46]

LGTM otherwise.

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc
File util/misc/uuid_test.cc (right):

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:156: TEST(UUID, FromString) {
const (and kCases?)

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:158: const char uuid_string[37];
Probably ought to be const char*, especially in light of comment about trailing
crap.

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:174: {"abcd", false},
You should also have a test case that is a valid UUID plus extra digits tacked
onto the end. That shouldn’t be interpreted as a valid UUID.

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:196:
uuid.InitializeFromString("F32E5BDC-2681-4C73-A4E6-911FFD89B846");
I was going to ask for this in the list of cases above, but I see why you didn’t
do that (the ToString() round-trip test).

You should at least add one more case here that mixes uppercase and lowercase
hex digits in a single UUID.

[Robert Sesek, 2015-01-02 23:46:00]

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc
File util/misc/uuid_test.cc (right):

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:156: TEST(UUID, FromString) {
On 2015/01/02 23:33:46, Mark Mentovai wrote:
> const (and kCases?)

Done.

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:158: const char uuid_string[37];
On 2015/01/02 23:33:46, Mark Mentovai wrote:
> Probably ought to be const char*, especially in light of comment about
trailing
> crap.

Done.

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:174: {"abcd", false},
On 2015/01/02 23:33:46, Mark Mentovai wrote:
> You should also have a test case that is a valid UUID plus extra digits tacked
> onto the end. That shouldn’t be interpreted as a valid UUID.

Done.

https://codereview.chromium.org/820783004/diff/1/util/misc/uuid_test.cc#newco...
util/misc/uuid_test.cc:196:
uuid.InitializeFromString("F32E5BDC-2681-4C73-A4E6-911FFD89B846");
On 2015/01/02 23:33:46, Mark Mentovai wrote:
> I was going to ask for this in the list of cases above, but I see why you
didn’t
> do that (the ToString() round-trip test).
> 
> You should at least add one more case here that mixes uppercase and lowercase
> hex digits in a single UUID.

Done.

[Robert Sesek, 2015-01-02 23:46:14]

Committed patchset #2 (id:20001) manually as
c75dc46b17d24735920a44f42e3981069e6f018a (presubmit successful).