Introduce CompletionTarget to take the place of the Node being completed.

pkg/analysis_server/test/services/completion/completion_test_util.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.util;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol show Element,
     ElementKind;
 import 'package:analysis_server/src/protocol.dart' hide Element, ElementKind;
 import 'package:analysis_server/src/services/completion/completion_manager.dart';
+import 'package:analysis_server/src/services/completion/completion_target.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_cache.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/imported_computer.dart';
 import 'package:analysis_server/src/services/completion/invocation_computer.dart';
 import 'package:analysis_server/src/services/completion/local_computer.dart';
 import 'package:analysis_server/src/services/index/index.dart';
 import 'package:analysis_server/src/services/index/local_memory_index.dart';
 import 'package:analysis_server/src/services/search/search_engine_internal.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
@@ skipping 391 matching lines @@
     }
   }
 
   bool computeFast() {
     _computeFastCalled = true;
     testUnit = context.parseCompilationUnit(testSource);
     completionNode =
         new NodeLocator.con1(completionOffset).searchWithin(testUnit);
     request.unit = testUnit;
     request.node = completionNode;
+    request.target = new CompletionTarget.forOffset(testUnit, completionOffset);
     return computer.computeFast(request);
   }
 
   Future computeFull(assertFunction(bool result), {bool fullAnalysis: true}) {
     if (!_computeFastCalled) {
       expect(computeFast(), isFalse);
     }
 
     // Index SDK
     for (Source librarySource in context.librarySources) {
@@ skipping 508 matching lines @@
       // the user may be either (1) entering a type for the assignment
       // or (2) starting a new statement.
       // Consider suggesting only types
       // if only spaces separates the 1st and 2nd identifiers.
       //assertNotSuggested('a');
       //assertNotSuggested('main');
       //assertNotSuggested('identical');
     });
   }
 
+  test_AssignmentExpression_type_newline() {
+    // SimpleIdentifier  TypeName  VariableDeclarationList
+    // VariableDeclarationStatement  Block
+    addTestSource('''
+      class A {} main() {
+        int a;
+        ^
+        b = 1;}''');
+    computeFast();
+    return computeFull((bool result) {
+      assertSuggestLocalClass('A');
+      assertSuggestImportedClass('int');
+      // Allow non-types preceding an identifier on LHS of assignment
+      // if newline follows first identifier
+      // because user is probably starting a new statement
+      assertSuggestLocalVariable('a', 'int');
+      assertSuggestLocalFunction('main', null);
+      assertSuggestImportedFunction('identical', 'bool');
+    });
+  }
+
   test_AssignmentExpression_type_partial() {
     // SimpleIdentifier  TypeName  VariableDeclarationList
     // VariableDeclarationStatement  Block
     addTestSource('''
       class A {} main() {
         int a;
         int^ b = 1;}''');
     computeFast();
     return computeFull((bool result) {
       assertSuggestLocalClass('A');
       assertSuggestImportedClass('int');
       // TODO (danrubel) When entering 1st of 2 identifiers on assignment LHS
       // the user may be either (1) entering a type for the assignment
       // or (2) starting a new statement.
       // Consider suggesting only types
       // if only spaces separates the 1st and 2nd identifiers.
       //assertNotSuggested('a');
       //assertNotSuggested('main');
       //assertNotSuggested('identical');
     });
   }
 
-  test_AssignmentExpression_type_newline() {
-    // SimpleIdentifier  TypeName  VariableDeclarationList
-    // VariableDeclarationStatement  Block
-    addTestSource('''
-      class A {} main() {
-        int a;
-        ^
-        b = 1;}''');
-    computeFast();
-    return computeFull((bool result) {
-      assertSuggestLocalClass('A');
-      assertSuggestImportedClass('int');
-      // Allow non-types preceding an identifier on LHS of assignment
-      // if newline follows first identifier
-      // because user is probably starting a new statement
-      assertSuggestLocalVariable('a', 'int');
-      assertSuggestLocalFunction('main', null);
-      assertSuggestImportedFunction('identical', 'bool');
-    });
-  }
-
   test_AssignmentExpression_type_partial_newline() {
     // SimpleIdentifier  TypeName  VariableDeclarationList
     // VariableDeclarationStatement  Block
     addTestSource('''
       class A {} main() {
         int a;
         i^
         b = 1;}''');
     computeFast();
     return computeFull((bool result) {
@@ skipping 1406 matching lines @@
       assertNotSuggested('bar2');
       assertNotSuggested('_B');
       assertSuggestLocalClass('Y');
       assertSuggestLocalClass('C');
       assertSuggestLocalVariable('f', null);
       assertNotSuggested('x');
       assertNotSuggested('e');
     });
   }
 }