Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 820733002: Fix some override usage in media/ (Closed)

Created:
6 years ago by dmichael (off chromium)
Modified:
6 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some override usage in media/ Currently, the Clang style checker ignores templates. In order to turn it on, we first must fix latent style violations. This CL covers media/ BUG=441916 R=dalecurtis@chromium.org Committed: https://crrev.com/5c2a4caa4e3eb8352167a647c48bb7ef0d78d00d Cr-Commit-Position: refs/heads/master@{#309268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M media/base/cdm_promise.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/cdm_result_promise.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dmichael (off chromium)
6 years ago (2014-12-19 19:49:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820733002/1
6 years ago (2014-12-19 19:51:40 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-19 19:51:42 UTC) #5
scherkus (not reviewing)
lgtm (he's OOO)
6 years ago (2014-12-19 19:52:04 UTC) #7
dmichael (off chromium)
On 2014/12/19 19:52:04, scherkus wrote: > lgtm (he's OOO) Oops, meant to TBR since it's ...
6 years ago (2014-12-19 19:59:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820733002/1
6 years ago (2014-12-19 20:00:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 21:39:11 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-19 21:39:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c2a4caa4e3eb8352167a647c48bb7ef0d78d00d
Cr-Commit-Position: refs/heads/master@{#309268}

Powered by Google App Engine
This is Rietveld 408576698