Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 820713008: [Extensions Toolbar Mac] Implement drag-and-drop for the overflow menu (Closed)

Created:
6 years ago by Devlin
Modified:
6 years ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar Mac] Implement drag-and-drop for the overflow menu Make the overflow menu for the extensions toolbar on mac work with drag-and- drop across multiple menu rows. Also adjust the visibility criteria for the overflow menu in the wrench menu model. TBR=sky@chromium.org (small wrench menu model change) BUG=429810 Committed: https://crrev.com/1337ccff19b0a3fb7a5b0b09aea345c911279cfe Cr-Commit-Position: refs/heads/master@{#309462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +26 lines, -18 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
6 years ago (2014-12-22 19:12:00 UTC) #2
Avi (use Gerrit)
lgtm
6 years ago (2014-12-22 19:14:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820713008/1
6 years ago (2014-12-22 20:49:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 21:04:36 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 21:05:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1337ccff19b0a3fb7a5b0b09aea345c911279cfe
Cr-Commit-Position: refs/heads/master@{#309462}

Powered by Google App Engine
This is Rietveld 408576698