[print preview] Improve appearance of select control separators.

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: cr/ui/print_preview_cloud.js
 
 var localStrings = new LocalStrings();
 
 // If useCloudPrint is true we attempt to connect to cloud print
 // and populate the list of printers with cloud print printers.
@@ skipping 518 matching lines @@
 }
 
 /**
  * Set the default printer. If there is one, generate a print preview.
  * @param {string} printer Name of the default printer. Empty if none.
  * @param {string} cloudPrintData Cloud print related data to restore if
  *                 the default printer is a cloud printer.
  */
 function setDefaultPrinter(printer_name, cloudPrintData) {
   // Add a placeholder value so the printer list looks valid.
-  addDestinationListOption('', '', true, true, true);
+  addDestinationListOption('', '', true, true);
   if (printer_name) {
     defaultOrLastUsedPrinterName = printer_name;
     if (cloudPrintData) {
       cloudprint.setDefaultPrinter(printer_name,
                                    cloudPrintData,
                                    addDestinationListOptionAtPosition,
                                    doUpdateCloudPrinterCapabilities);
     } else {
       $('printer-list')[0].value = defaultOrLastUsedPrinterName;
       updateControlsWithSelectedPrinterCapabilities();
     }
   }
   chrome.send('getPrinters');
 }
 
 /**
  * Fill the printer list drop down.
  * Called from PrintPreviewHandler::SendPrinterList().
  * @param {Array} printers Array of printer info objects.
  */
 function setPrinters(printers) {
   var printerList = $('printer-list');
   // Remove empty entry added by setDefaultPrinter.
   if (printerList[0] && printerList[0].textContent == '')
     printerList.remove(0);
   for (var i = 0; i < printers.length; ++i) {
     var isDefault = (printers[i].deviceName == defaultOrLastUsedPrinterName);
     addDestinationListOption(printers[i].printerName, printers[i].deviceName,
-                             isDefault, false, false);
+                             isDefault, false);
   }
 
   if (printers.length != 0)
-    addDestinationListOption('', '', false, true, true);
+    addDestinationListSeparator();
 
   // Adding option for saving PDF to disk.
   addDestinationListOption(localStrings.getString('printToPDF'),
                            PRINT_TO_PDF,
                            defaultOrLastUsedPrinterName == PRINT_TO_PDF,
-                           false,
                            false);
-  addDestinationListOption('', '', false, true, true);
+  addDestinationListSeparator();
   if (useCloudPrint) {
     addDestinationListOption(localStrings.getString('printWithCloudPrint'),
                              PRINT_WITH_CLOUD_PRINT,
                              false,
-                             false,
                              false);
-    addDestinationListOption('', '', false, true, true);
+    addDestinationListSeparator();
   }
   // Add options to manage printers.
   if (!cr.isChromeOS) {
     addDestinationListOption(localStrings.getString('managePrinters'),
-        MANAGE_LOCAL_PRINTERS, false, false, false);
+        MANAGE_LOCAL_PRINTERS, false, false);
   } else if (useCloudPrint) {
     // Fetch recent printers.
     cloudprint.fetchPrinters(addDestinationListOptionAtPosition, false);
     // Fetch the full printer list.
     cloudprint.fetchPrinters(addDestinationListOptionAtPosition, true);
     addDestinationListOption(localStrings.getString('managePrinters'),
-        MANAGE_CLOUD_PRINTERS, false, false, false);
+        MANAGE_CLOUD_PRINTERS, false, false);
   }
 
   printerList.disabled = false;
 
   if (!hasRequestedPreview())
     updateControlsWithSelectedPrinterCapabilities();
 }
 
 /**
  * Creates an option that can be added to the printer destination list.
  * @param {string} optionText specifies the option text content.
  * @param {string} optionValue specifies the option value.
  * @param {boolean} isDefault is true if the option needs to be selected.
  * @param {boolean} isDisabled is true if the option needs to be disabled.
- * @param {boolean} isSeparator is true if the option is a visual separator and
- *     needs to be disabled.
  * @return {Object} The created option.
  */
 function createDestinationListOption(optionText, optionValue, isDefault,
-    isDisabled, isSeparator) {
+    isDisabled) {
   var option = document.createElement('option');
   option.textContent = optionText;
   option.value = optionValue;
   option.selected = isDefault;
-  option.disabled = isSeparator || isDisabled;
-  // Adding attribute for improved accessibility.
-  if (isSeparator)
-    option.setAttribute("role", "separator");
+  option.disabled = isDisabled;
   return option;
 }
 
 /**
  * Adds an option to the printer destination list.
  * @param {string} optionText specifies the option text content.
  * @param {string} optionValue specifies the option value.
  * @param {boolean} isDefault is true if the option needs to be selected.
  * @param {boolean} isDisabled is true if the option needs to be disabled.
  * @return {Object} The created option.
  */
 function addDestinationListOption(optionText, optionValue, isDefault,
-    isDisabled, isSeparator) {
+    isDisabled) {
   var option = createDestinationListOption(optionText,
                                            optionValue,
                                            isDefault,
-                                           isDisabled,
-                                           isSeparator);
+                                           isDisabled);
   $('printer-list').add(option);
   return option;
 }
 
 /**
  * Adds an option to the printer destination list at a specified position.
  * @param {number} position The index in the printer-list wher the option
        should be created.
  * @param {string} optionText specifies the option text content.
  * @param {string} optionValue specifies the option value.
  * @param {boolean} isDefault is true if the option needs to be selected.
  * @param {boolean} isDisabled is true if the option needs to be disabled.
  * @return {Object} The created option.
  */
 function addDestinationListOptionAtPosition(position,
                                             optionText,
                                             optionValue,
                                             isDefault,
-                                            isDisabled,
-                                            isSeparator) {
+                                            isDisabled) {
   var option = createDestinationListOption(optionText,
                                            optionValue,
                                            isDefault,
-                                           isDisabled,
-                                           isSeparator);
+                                           isDisabled);
   var printerList = $('printer-list');
   var before = printerList[position];
   printerList.add(option, before);
   return option;
 }
+
+/**
+ * Adds a separator to the printer destination list.
+ */
+function addDestinationListSeparator() {
+  $('printer-list').add(document.createElement('hr'));
+}
+
 /**
  * Sets the color mode for the PDF plugin.
  * Called from PrintPreviewHandler::ProcessColorSetting().
  * @param {boolean} color is true if the PDF plugin should display in color.
  */
 function setColor(color) {
   var pdfViewer = $('pdf-viewer');
   if (!pdfViewer) {
     return;
   }
@@ skipping 342 matching lines @@
 <include src="print_preview_animations.js"/>
 <include src="print_preview_cloud.js"/>
 <include src="print_preview_utils.js"/>
 <include src="print_header.js"/>
 <include src="page_settings.js"/>
 <include src="copies_settings.js"/>
 <include src="header_footer_settings.js"/>
 <include src="layout_settings.js"/>
 <include src="color_settings.js"/>
 <include src="margin_settings.js"/>