Issue 820683005: add SkGeometry.h to core.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 820683005: add SkGeometry.h to core.gypi (Closed)

Created:
5 years, 11 months ago by reed1

Modified:
5 years, 11 months ago

Reviewers:
tfarina

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

add SkGeometry.h to core.gypi BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/5f2ee72f975d8172a65808af7fc4985b40b7ca28

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gyp/core.gypi	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820683005/1

5 years, 11 months ago (2015-01-05 14:02:39 UTC) #2

tfarina

https://codereview.chromium.org/820683005/diff/1/gyp/core.gypi File gyp/core.gypi (right): https://codereview.chromium.org/820683005/diff/1/gyp/core.gypi#newcode101 gyp/core.gypi:101: '<(skia_src_path)/core/SkGeometry.h', lgtm

5 years, 11 months ago (2015-01-05 14:34:18 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-05 14:47:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5f2ee72f975d8172a65808af7fc4985b40b7ca28

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages