Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 820683002: When bitmap is texture backed, don't download and reupload pixels (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

When bitmap is texture backed, don't download and reupload pixels Committed: https://skia.googlesource.com/skia/+/9ed7f573491217079cccf1d81792cf4520a3c0d0

Patch Set 1 #

Patch Set 2 : fix for npot case #

Patch Set 3 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M src/gpu/SkGr.cpp View 1 2 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
6 years ago (2014-12-19 16:17:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820683002/1
6 years ago (2014-12-19 16:18:04 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-19 16:18:05 UTC) #5
bsalomon
now with workaround for npot issue
6 years ago (2014-12-19 18:19:09 UTC) #7
robertphillips
lgtm
6 years ago (2014-12-19 18:44:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820683002/40001
6 years ago (2014-12-19 18:55:04 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-19 20:26:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9ed7f573491217079cccf1d81792cf4520a3c0d0

Powered by Google App Engine
This is Rietveld 408576698