chrome/browser/chromeos/extensions/wallpaper_function_base.h - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_function_base.h

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_api.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_function_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/wallpaper_function_base.h

diff --git a/chrome/browser/chromeos/extensions/wallpaper_function_base.h b/chrome/browser/chromeos/extensions/wallpaper_function_base.h

index 5cc99762f4540fe0de6ca2a17a4709d768b087a9..97c1691d73d4fceea28958d866ef54996243c72e 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_function_base.h

+++ b/chrome/browser/chromeos/extensions/wallpaper_function_base.h

@@ -5,6 +5,9 @@

#ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_WALLPAPER_FUNCTION_BASE_H_

#define CHROME_BROWSER_CHROMEOS_EXTENSIONS_WALLPAPER_FUNCTION_BASE_H_

+#include <string>

+#include <vector>

#include "ash/desktop_background/desktop_background_controller.h"

#include "components/wallpaper/wallpaper_layout.h"

#include "extensions/browser/extension_function.h"

@@ -31,7 +34,7 @@ class WallpaperFunctionBase : public AsyncExtensionFunction {

static UnsafeWallpaperDecoder* unsafe_wallpaper_decoder_;

// Starts to decode |data|. Must run on UI thread.

- void StartDecode(const std::string& data);

+ void StartDecode(const std::vector<char>& data);

// Handles cancel case. No error message should be set.

void OnCancel();