chromeos/dbus/fake_shill_third_party_vpn_driver_client.h - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_third_party_vpn_driver_client.h

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values_unittest.cc ('K') | « chrome/browser/notifications/notification_conversion_helper.cc ('k') | chromeos/dbus/fake_shill_third_party_vpn_driver_client.cc » ('j') | chromeos/dbus/shill_third_party_vpn_driver_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/dbus/fake_shill_third_party_vpn_driver_client.h

diff --git a/chromeos/dbus/fake_shill_third_party_vpn_driver_client.h b/chromeos/dbus/fake_shill_third_party_vpn_driver_client.h

index 601ef31ab4351f4954508549d0c2722e5abafbe6..f4dae5c4aab34de397cd365b2b814c5077eb339b 100644

--- a/chromeos/dbus/fake_shill_third_party_vpn_driver_client.h

+++ b/chromeos/dbus/fake_shill_third_party_vpn_driver_client.h

@@ -42,14 +42,14 @@ class CHROMEOS_EXPORT FakeShillThirdPartyVpnDriverClient

const ShillClientHelper::ErrorCallback& error_callback) override;

void SendPacket(

const std::string& object_path_value,

- const std::string& ip_packet,

+ const std::vector<char>& ip_packet,

const base::Closure& callback,

const ShillClientHelper::ErrorCallback& error_callback) override;

ShillThirdPartyVpnDriverClient::TestInterface* GetTestInterface() override;

// ShillThirdPartyVpnDriverClient::TestInterface overrides

void OnPacketReceived(const std::string& object_path_value,

- const std::string& packet) override;

+ const std::vector<char>& packet) override;

void OnPlatformMessage(const std::string& object_path_value,

uint32_t message) override;