chrome/browser/extensions/api/copresence/copresence_api_unittest.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values_unittest.cc ('K') | « chrome/browser/extensions/api/copresence/copresence_api.cc ('k') | chrome/browser/extensions/api/copresence/copresence_translations.cc » ('j') | chromeos/dbus/shill_third_party_vpn_driver_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

diff --git a/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc b/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

index 5c803d39dbebc100253ba4e1698298de11ea5d8b..4ab19e94ca1b785f2e2441c9130dd204ee01df41 100644

--- a/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

+++ b/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include "base/json/json_writer.h"

+#include "base/macros.h"

#include "base/values.h"

#include "chrome/browser/extensions/api/copresence/copresence_api.h"

#include "chrome/browser/extensions/extension_api_unittest.h"

@@ -43,7 +44,8 @@ PublishOperation* CreatePublish(const std::string& id) {

publish->id = id;

publish->time_to_live_millis.reset(new int(1000));

publish->message.type = "joke";

- publish->message.payload = "Knock Knock!";

+ const char kPayload[] = "Knock Knock!";

+ publish->message.payload.assign(kPayload, kPayload + arraysize(kPayload));

return publish;

}