chrome/browser/chromeos/extensions/wallpaper_api.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_api.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values_unittest.cc ('K') | « base/values_unittest.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_function_base.h » ('j') | chromeos/dbus/shill_third_party_vpn_driver_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/wallpaper_api.cc

diff --git a/chrome/browser/chromeos/extensions/wallpaper_api.cc b/chrome/browser/chromeos/extensions/wallpaper_api.cc

index fbd1fdc9b7ee1fb49df375fd54c9a7e8bf4b0c32..971d603da3c0105a56e651e476c8dd98b9d3e476 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_api.cc

+++ b/chrome/browser/chromeos/extensions/wallpaper_api.cc

@@ -4,6 +4,9 @@

#include "chrome/browser/chromeos/extensions/wallpaper_api.h"

+#include <string>

+#include <vector>

#include "ash/desktop_background/desktop_background_controller.h"

#include "base/files/file_util.h"

#include "base/lazy_instance.h"

@@ -205,7 +208,8 @@ void WallpaperSetWallpaperFunction::OnWallpaperFetched(

bool success,

const std::string& response) {

if (success) {

- params_->details.data.reset(new std::string(response));

+ params_->details.data.reset(

+ new std::vector<char>(response.begin(), response.end()));

StartDecode(*params_->details.data);

} else {

SetError(response);