json_schema_compiler: Use std::vector<char> for binary values.

extensions/browser/api/serial/serial_connection.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/serial/serial_connection.h"
 
 #include <string>
+#include <vector>
 
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop/message_loop.h"
+#include "base/stl_util.h"
 #include "extensions/browser/api/api_resource_manager.h"
 #include "extensions/common/api/serial.h"
 
 namespace extensions {
 
 namespace {
 
 const int kDefaultBufferSize = 4096;
 
 core_api::serial::SendError ConvertSendErrorFromMojo(
@@ skipping 108 matching lines @@
       return device::serial::STOP_BITS_ONE;
     case core_api::serial::STOP_BITS_TWO:
       return device::serial::STOP_BITS_TWO;
   }
   return device::serial::STOP_BITS_NONE;
 }
 
 class SendBuffer : public device::ReadOnlyBuffer {
  public:
   SendBuffer(
-      const std::string& data,
+      const std::vector<char>& data,
       const base::Callback<void(int, device::serial::SendError)>& callback)
       : data_(data), callback_(callback) {}
   ~SendBuffer() override {}
-  const char* GetData() override { return data_.c_str(); }
+  const char* GetData() override { return vector_as_array(&data_); }
   uint32_t GetSize() override { return static_cast<uint32_t>(data_.size()); }
   void Done(uint32_t bytes_read) override {
     callback_.Run(bytes_read, device::serial::SEND_ERROR_NONE);
   }
   void DoneWithError(uint32_t bytes_read, int32_t error) override {
     callback_.Run(bytes_read, static_cast<device::serial::SendError>(error));
   }
 
  private:
-  const std::string data_;
+  const std::vector<char> data_;
   const base::Callback<void(int, device::serial::SendError)> callback_;
 };
 
 class ReceiveBuffer : public device::WritableBuffer {
  public:
   ReceiveBuffer(
       scoped_refptr<net::IOBuffer> buffer,
       uint32_t size,
       const base::Callback<void(int, device::serial::ReceiveError)>& callback)
       : buffer_(buffer), size_(size), callback_(callback) {}
@@ skipping 89 matching lines @@
       base::Bind(&SerialConnection::OnAsyncReadComplete, AsWeakPtr()))));
   receive_timeout_task_.reset();
   if (receive_timeout_ > 0) {
     receive_timeout_task_.reset(new TimeoutTask(
         base::Bind(&SerialConnection::OnReceiveTimeout, AsWeakPtr()),
         base::TimeDelta::FromMilliseconds(receive_timeout_)));
   }
   return true;
 }
 
-bool SerialConnection::Send(const std::string& data,
+bool SerialConnection::Send(const std::vector<char>& data,
                             const SendCompleteCallback& callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (!send_complete_.is_null())
     return false;
   send_complete_ = callback;
   io_handler_->Write(scoped_ptr<device::ReadOnlyBuffer>(new SendBuffer(
       data, base::Bind(&SerialConnection::OnAsyncWriteComplete, AsWeakPtr()))));
   send_timeout_task_.reset();
   if (send_timeout_ > 0) {
     send_timeout_task_.reset(new TimeoutTask(
@@ skipping 81 matching lines @@
   io_handler_->CancelWrite(device::serial::SEND_ERROR_TIMEOUT);
 }
 
 void SerialConnection::OnAsyncReadComplete(int bytes_read,
                                            device::serial::ReceiveError error) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK(!receive_complete_.is_null());
   ReceiveCompleteCallback callback = receive_complete_;
   receive_complete_.Reset();
   receive_timeout_task_.reset();
-  callback.Run(std::string(receive_buffer_->data(), bytes_read),
+  callback.Run(std::vector<char>(receive_buffer_->data(),
+                                 receive_buffer_->data() + bytes_read),
                ConvertReceiveErrorFromMojo(error));
   receive_buffer_ = NULL;
 }
 
 void SerialConnection::OnAsyncWriteComplete(int bytes_sent,
                                             device::serial::SendError error) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK(!send_complete_.is_null());
   SendCompleteCallback callback = send_complete_;
   send_complete_.Reset();
@@ skipping 52 matching lines @@
   output->parity_bit = extensions::ConvertParityBitToMojo(input.parity_bit);
   output->stop_bits = extensions::ConvertStopBitsToMojo(input.stop_bits);
   if (input.cts_flow_control.get()) {
     output->has_cts_flow_control = true;
     output->cts_flow_control = *input.cts_flow_control;
   }
   return output.Pass();
 }
 
 }  // namespace mojo