Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: src/typing.cc

Issue 820673002: Follow-on to hydrogen fix keyed loads with string keys for vector ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/typing.h" 5 #include "src/typing.h"
6 6
7 #include "src/frames.h" 7 #include "src/frames.h"
8 #include "src/frames-inl.h" 8 #include "src/frames-inl.h"
9 #include "src/ostreams.h" 9 #include "src/ostreams.h"
10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move 10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 if (FLAG_vector_ics) { 503 if (FLAG_vector_ics) {
504 oracle()->PropertyReceiverTypes(slot, name, expr->GetReceiverTypes()); 504 oracle()->PropertyReceiverTypes(slot, name, expr->GetReceiverTypes());
505 } else { 505 } else {
506 oracle()->PropertyReceiverTypes(id, name, expr->GetReceiverTypes()); 506 oracle()->PropertyReceiverTypes(id, name, expr->GetReceiverTypes());
507 } 507 }
508 } else { 508 } else {
509 bool is_string; 509 bool is_string;
510 IcCheckType key_type; 510 IcCheckType key_type;
511 if (FLAG_vector_ics) { 511 if (FLAG_vector_ics) {
512 oracle()->KeyedPropertyReceiverTypes(slot, expr->GetReceiverTypes(), 512 oracle()->KeyedPropertyReceiverTypes(slot, expr->GetReceiverTypes(),
513 &is_string); 513 &is_string, &key_type);
514 key_type = ELEMENT;
515 } else { 514 } else {
516 oracle()->KeyedPropertyReceiverTypes(id, expr->GetReceiverTypes(), 515 oracle()->KeyedPropertyReceiverTypes(id, expr->GetReceiverTypes(),
517 &is_string, &key_type); 516 &is_string, &key_type);
518 } 517 }
519 expr->set_is_string_access(is_string); 518 expr->set_is_string_access(is_string);
520 expr->set_key_type(key_type); 519 expr->set_key_type(key_type);
521 } 520 }
522 } 521 }
523 522
524 RECURSE(Visit(expr->obj())); 523 RECURSE(Visit(expr->obj()));
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 808 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
810 } 809 }
811 810
812 811
813 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 812 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
814 RECURSE(Visit(stmt->body())); 813 RECURSE(Visit(stmt->body()));
815 } 814 }
816 815
817 816
818 } } // namespace v8::internal 817 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698