Issue 820673002: Follow-on to hydrogen fix keyed loads with string keys for vector ics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 820673002: Follow-on to hydrogen fix keyed loads with string keys for vector ics. (Closed)

Created:
6 years ago by mvstanton

Modified:
6 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Follow-on to hydrogen fix keyed loads with string keys for vector ics. r25817 optimized hydrogen keyed loads with string keys. (https://codereview.chromium.org/755513003). This CL adapts that work for the vector-ic keyed load. BUG= Committed: https://crrev.com/efd1f3ea2d6a14fd0282ed83aa48fcfeb7eb6ae6 Cr-Commit-Position: refs/heads/master@{#25903}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
M	src/type-info.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/type-info.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/typing.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820673002/1

6 years ago (2014-12-19 13:13:26 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-19 13:41:18 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/efd1f3ea2d6a14fd0282ed83aa48fcfeb7eb6ae6
Cr-Commit-Position: refs/heads/master@{#25903}