Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 820643005: Allow -DGOOGLE3 to bypass our normal platform intrinsic dispatch. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow -DGOOGLE3 to bypass our normal platform intrinsic dispatch. The current code that pound-includes another define doesn't seem to be working there. BUG=skia: No API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/e55fb177e9435daa7db88614fe181717002689fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M include/core/SkThread.h View 3 chunks +15 lines, -3 lines 0 comments Download
M include/core/SkThreadPriv.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
5 years, 11 months ago (2015-01-13 20:25:17 UTC) #2
jcgregorio
lgtm
5 years, 11 months ago (2015-01-13 21:15:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820643005/1
5 years, 11 months ago (2015-01-13 21:17:24 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:27:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e55fb177e9435daa7db88614fe181717002689fc

Powered by Google App Engine
This is Rietveld 408576698