Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 820633002: Reset mode on ancestors when a fullscreen node is removed. (Closed)

Created:
6 years ago by Olle Liljenzin
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reset mode on ancestors when a fullscreen node is removed. Element::removedFrom() is called after a node has been detached and the parent pointer has been cleared. Thus fullscreen mode has to be reset on ancestors both in the removed tree and the tree it was linked into before it was detached. The patch fixes a corner case where :-webkit-full-screen-ancestor style was still applied on ancestors after the parent of a fullscreen node was removed. BUG=447184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M LayoutTests/fullscreen/full-screen-remove-ancestor-after.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Olle Liljenzin
Please review.
6 years ago (2014-12-19 08:42:58 UTC) #1
philipj_slow
Can you link to an existing bug or create one if needed? For stuff that ...
5 years, 11 months ago (2015-01-08 11:01:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820633002/1
5 years, 11 months ago (2015-01-08 14:56:35 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 14:59:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188050

Powered by Google App Engine
This is Rietveld 408576698