Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 820603002: [Telemetry] Make psutil use the new external_modules helper. (Closed)

Created:
6 years ago by tonyg
Modified:
5 years, 11 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Make psutil use the new external_modules helper. BUG= Committed: https://crrev.com/58dd79db9d17bdea6aef5d3e8d6fe055343791df Cr-Commit-Position: refs/heads/master@{#313132}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 3 chunks +4 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/util/external_modules.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tonyg
6 years ago (2014-12-19 01:29:07 UTC) #2
mthiesse
lgtm
6 years ago (2014-12-19 01:35:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820603002/20001
6 years ago (2014-12-19 02:07:42 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-19 02:07:44 UTC) #7
tonyg
Dave, would you mind?
6 years ago (2014-12-19 02:22:31 UTC) #9
fmeawad
On 2014/12/19 02:22:31, tonyg wrote: > Dave, would you mind? LGTM
5 years, 11 months ago (2015-01-26 19:44:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820603002/20001
5 years, 11 months ago (2015-01-26 19:47:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 20:50:54 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:52:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58dd79db9d17bdea6aef5d3e8d6fe055343791df
Cr-Commit-Position: refs/heads/master@{#313132}

Powered by Google App Engine
This is Rietveld 408576698