Adds support for media permission request handling on <appview> tag.

extensions/browser/guest_view/app_view/app_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/app_view/app_view_guest.h"
 
 #include "base/command_line.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/renderer_preferences.h"
 #include "extensions/browser/api/app_runtime/app_runtime_api.h"
 #include "extensions/browser/api/extensions_api_client.h"
+#include "extensions/browser/app_window/app_delegate.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/guest_view/app_view/app_view_constants.h"
 #include "extensions/browser/guest_view/guest_view_manager.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/api/app_runtime.h"
@@ skipping 75 matching lines @@
 
 AppViewGuest::AppViewGuest(content::BrowserContext* browser_context,
                            content::WebContents* owner_web_contents,
                            int guest_instance_id)
     : GuestView<AppViewGuest>(browser_context,
                               owner_web_contents,
                               guest_instance_id),
       app_view_guest_delegate_(
           ExtensionsAPIClient::Get()->CreateAppViewGuestDelegate()),
       weak_ptr_factory_(this) {
+  if (app_view_guest_delegate_)
+    app_delegate_.reset(app_view_guest_delegate_->CreateAppDelegate());
 }
 
 AppViewGuest::~AppViewGuest() {
 }
 
 WindowController* AppViewGuest::GetExtensionWindowController() const {
   return NULL;
 }
 
 content::WebContents* AppViewGuest::GetAssociatedWebContents() const {
   return web_contents();
 }
 
 bool AppViewGuest::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AppViewGuest, message)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 bool AppViewGuest::HandleContextMenu(const content::ContextMenuParams& params) {
   if (app_view_guest_delegate_) {
     return app_view_guest_delegate_->HandleContextMenu(web_contents(), params);
   }
   return false;
 }
 
+void AppViewGuest::RequestMediaAccessPermission(
+    content::WebContents* web_contents,
+    const content::MediaStreamRequest& request,
+    const content::MediaResponseCallback& callback) {
+  if (!app_delegate_) {
+    WebContentsDelegate::RequestMediaAccessPermission(web_contents, request,
+                                                      callback);

[Fady Samuel, 2014/12/19 11:21:51]

early exit after so you don't need else. Slight improvement to readability.

[lfg, 2014/12/19 16:29:08]

Done.

+  } else {
+    const ExtensionSet& enabled_extensions =
+        ExtensionRegistry::Get(browser_context())->enabled_extensions();
+    const Extension* guest_extension =
+        enabled_extensions.GetByID(guest_extension_id_);
+
+    app_delegate_->RequestMediaAccessPermission(web_contents, request, callback,
+                                                guest_extension);
+  }
+}
+
+bool AppViewGuest::CheckMediaAccessPermission(
+    content::WebContents* web_contents,
+    const GURL& security_origin,
+    content::MediaStreamType type) {
+  if (!app_delegate_) {
+    return WebContentsDelegate::CheckMediaAccessPermission(
+        web_contents, security_origin, type);

[Fady Samuel, 2014/12/19 11:21:51]

early exit then remove else.

[lfg, 2014/12/19 16:29:08]

Done.

+  } else {
+    const ExtensionSet& enabled_extensions =
+        ExtensionRegistry::Get(browser_context())->enabled_extensions();
+    const Extension* guest_extension =
+        enabled_extensions.GetByID(guest_extension_id_);
+
+    return app_delegate_->CheckMediaAccessPermission(
+        web_contents, security_origin, type, guest_extension);
+  }
+}
+
 const char* AppViewGuest::GetAPINamespace() const {
   return appview::kEmbedderAPINamespace;
 }
 
 int AppViewGuest::GetTaskPrefix() const {
   return IDS_EXTENSION_TASK_MANAGER_APPVIEW_TAG_PREFIX;
 }
 
 void AppViewGuest::CreateWebContents(
     const base::DictionaryValue& create_params,
@@ skipping 105 matching lines @@
   }
 
   scoped_ptr<base::DictionaryValue> embed_request(new base::DictionaryValue());
   embed_request->SetInteger(appview::kGuestInstanceID, guest_instance_id());
   embed_request->SetString(appview::kEmbedderID, owner_extension_id());
   embed_request->Set(appview::kData, data.release());
   AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent(
       browser_context(), embed_request.Pass(), extension_host->extension());
 }
 
+void AppViewGuest::SetAppDelegateForTest(AppDelegate* delegate) {
+  app_delegate_.reset(delegate);
+}
+
 }  // namespace extensions