LayoutTests/crypto/subtle/clone-pbkdf2Key.html - Issue 820523003: [webcrypto] Implement PBKDF2 (blink-side)

Side by Side Diff: LayoutTests/crypto/subtle/clone-pbkdf2Key.html

Issue 820523003: [webcrypto] Implement PBKDF2 (blink-side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase and structured cloning test Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 <script src="resources/common.js"></script>	5 <script src="resources/common.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <p id="description"></p>	8 <p id="description"></p>

9 <div id="console"></div>	9 <div id="console"></div>

10	10

11 <script>	11 <script>

12 description("Tests structured cloning of HMAC keys");	12 description("Tests structured cloning of PBKDF2 keys");

13	13

14 jsTestIsAsync = true;	14 jsTestIsAsync = true;

15	15

16 // Tests the 48 permutations of keys generated by:	16 // Tests the 18 permutations of keys generated by:

17 // kPossibleHashAlgorithms x kPossibleExtractable x kPossibleKeyUsages x kPoss ibleKeyData	17 // kPossibleHashAlgorithms x kPossibleKeyUsages x kPossibleKeyData

18 //	18 //

19 // For practical reasons these tests are not exhaustive.	19 // For practical reasons these tests are not exhaustive.

20	20

21 var k128BitData = "30112233445566778899aabbccddeeff"	21 var k128BitData = "30112233445566778899aabbccddeeff"

22 var k256BitData = "00112233445546778899aabbccddeeff000102030405060708090a0b0c0d0 e0f";	22 var k256BitData = "00112233445546778899aabbccddeeff000102030405060708090a0b0c0d0 e0f";
	eroman 2015/01/14 21:12:22 Could you change the data lengths to some more int Could you change the data lengths to some more interesting values? * 0 bytes * 1 byte * 11 bytes (or something other than 16 and 32) I suggest this because the PBKDF2 key can be arbitrary length so a bit more variety in the key lengths makes for a good test. xun.sun 2015/01/15 17:13:29 Done. Now testing with passwords of 1 byte, 8 byte Show quoted text On 2015/01/14 21:12:22, eroman wrote: > Could you change the data lengths to some more interesting values? > > * 0 bytes > * 1 byte > * 11 bytes (or something other than 16 and 32) > > I suggest this because the PBKDF2 key can be arbitrary length so a bit more > variety in the key lengths makes for a good test. Done. Now testing with passwords of 1 byte, 8 bytes, and 11 bytes. I'm a bit hesitant with 0 bytes because I think empty passwords don't make sense but the spec does not request to reject them? eroman 2015/01/15 22:28:57 It should be easy to add an empty password case, c Show quoted text On 2015/01/15 17:13:29, xun.sun wrote: > On 2015/01/14 21:12:22, eroman wrote: > > Could you change the data lengths to some more interesting values? > > > > * 0 bytes > > * 1 byte > > * 11 bytes (or something other than 16 and 32) > > > > I suggest this because the PBKDF2 key can be arbitrary length so a bit more > > variety in the key lengths makes for a good test. > > Done. Now testing with passwords of 1 byte, 8 bytes, and 11 bytes. I'm a bit > hesitant with 0 bytes because I think empty passwords don't make sense but the > spec does not request to reject them? It should be easy to add an empty password case, can you add it to this CL? If you are having problems then it is OK to do so in a follow-up CL. Independent of whether empty length is allowed or rejected by the spec, it is important to have a test for it, since empty input is the sort of boundary case that has a good chance of causing problems in the implementation. Since these inputs are user-controlled, we need to be very careful that they cannot lead to problems. Historically crypto library haven't been hardened against invalid inputs, so testing these cases is important.
23	23

24 var kPossibleHashAlgorithms = ['SHA-1', 'SHA-256', 'SHA-512'];	24 var kPossibleHashAlgorithms = ['SHA-1', 'SHA-256', 'SHA-512'];

25 var kPossibleExtractable = [true, false];	25 var kPossibleKeyUsages = [['deriveBits'], ['deriveKey'], ['deriveKey', 'deriveBi ts']];

26 var kPossibleKeyUsages = [['sign'], ['verify'], ['sign', 'verify']];

27 var kPossibleKeyData = [	26 var kPossibleKeyData = [

28 k128BitData,	27 k128BitData,

29 k256BitData	28 k256BitData

30 ];	29 ];

31	30

32 function runTest(hashName, extractable, keyUsages, keyData)	31 function runTest(hashName, keyUsages, keyData)

33 {	32 {

34 var importData = hexStringToUint8Array(keyData);	33 var importData = hexStringToUint8Array(keyData);

35 var importAlgorithm = { name: 'HMAC', hash: {name: hashName } };	34 var importAlgorithm = { name: 'PBKDF2', hash: {name: hashName } };

	35 var extractable = false;

36	36

37 var results = {};	37 var results = {};

38	38

39 return crypto.subtle.importKey('raw', importData, importAlgorithm, extractab le, keyUsages).then(function(importedKey) {	39 return crypto.subtle.importKey('raw', importData, importAlgorithm, extractab le, keyUsages).then(function(importedKey) {

40 results.importedKey = importedKey;	40 results.importedKey = importedKey;

41 importedKey.extraProperty = 'hi';	41 importedKey.extraProperty = 'hi';

42 return cloneKey(importedKey);	42 return cloneKey(importedKey);

43 }).then(function(clonedKey) {	43 }).then(function(result) {

44 results.clonedKey = clonedKey;	44 results.clonedKey = result;

45 if (extractable)

46 return crypto.subtle.exportKey('raw', clonedKey);

47 return null;

48 }).then(function(clonedKeyData) {

49 importedKey = results.importedKey;	45 importedKey = results.importedKey;

50 clonedKey = results.clonedKey;	46 clonedKey = results.clonedKey;

51	47

52 shouldEvaluateAs("importedKey.extraProperty", "hi");	48 shouldEvaluateAs("importedKey.extraProperty", "hi");

53 shouldEvaluateAs("importedKey.type", "secret");	49 shouldEvaluateAs("importedKey.type", "secret");

54 shouldEvaluateAs("importedKey.extractable", extractable);	50 shouldEvaluateAs("importedKey.extractable", extractable);

55 shouldEvaluateAs("importedKey.algorithm.name", "HMAC");	51 shouldEvaluateAs("importedKey.algorithm.name", "PBKDF2");

56 shouldEvaluateAs("importedKey.algorithm.length", importData.length * 8);

57 shouldEvaluateAs("importedKey.algorithm.hash.name", hashName);

58 shouldEvaluateAs("importedKey.usages.join(',')", keyUsages.join(","));	52 shouldEvaluateAs("importedKey.usages.join(',')", keyUsages.join(","));

59	53

60 shouldNotBe("importedKey", "clonedKey");	54 shouldNotBe("importedKey", "clonedKey");

61	55

62 shouldBeUndefined("clonedKey.extraProperty");	56 shouldBeUndefined("clonedKey.extraProperty");

63 shouldEvaluateAs("clonedKey.type", "secret");	57 shouldEvaluateAs("clonedKey.type", "secret");

64 shouldEvaluateAs("clonedKey.extractable", extractable);	58 shouldEvaluateAs("clonedKey.extractable", extractable);

65 shouldEvaluateAs("clonedKey.algorithm.name", "HMAC");	59 shouldEvaluateAs("clonedKey.algorithm.name", "PBKDF2");

66 shouldEvaluateAs("clonedKey.algorithm.length", importData.length * 8);

67 shouldEvaluateAs("clonedKey.algorithm.hash.name", hashName);

68 shouldEvaluateAs("clonedKey.usages.join(',')", keyUsages.join(","));	60 shouldEvaluateAs("clonedKey.usages.join(',')", keyUsages.join(","));

69	61

70 logSerializedKey(importedKey);	62 logSerializedKey(importedKey);

71	63

72 if (extractable)

73 bytesShouldMatchHexString("Cloned key exported data", keyData, clone dKeyData);

74

75 debug("");	64 debug("");

76 });	65 });

77 }	66 }

78	67

79 var lastPromise = Promise.resolve(null);	68 var lastPromise = Promise.resolve(null);

80	69

81 kPossibleHashAlgorithms.forEach(function(hashName) {	70 kPossibleHashAlgorithms.forEach(function(hashName) {

82 kPossibleExtractable.forEach(function(extractable) {

83 kPossibleKeyUsages.forEach(function(keyUsages) {	71 kPossibleKeyUsages.forEach(function(keyUsages) {

84 kPossibleKeyData.forEach(function(keyData) {	72 kPossibleKeyData.forEach(function(keyData) {

85 lastPromise = lastPromise.then(runTest.bind(null, hashName, extr actable, keyUsages, keyData));	73 lastPromise = lastPromise.then(runTest.bind(null, hashName, keyU sages, keyData));

86 });	74 });

87 });	75 });

88 });

89 });	76 });

90	77

91 lastPromise.then(finishJSTest, failAndFinishJSTest);	78 lastPromise.then(finishJSTest, failAndFinishJSTest);

92	79

93 </script>	80 </script>

94	81

95 </body>	82 </body>

96 </html>	83 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/crypto/subtle/clone-pbkdf2Key-expected.txt » ('j') | LayoutTests/crypto/subtle/pbkdf2-deriveBits.html » ('J')