Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 820503005: Use SetOwnElement when creating splice records in array length setter (Closed)

Created:
6 years ago by adamk
Modified:
6 years ago
CC:
v8-dev, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use SetOwnElement when creating splice records in array length setter This avoids touching the Array prototype, which may have been tampered with. BUG=chromium:443982 LOG=n Committed: https://crrev.com/1f1329d960fcd8bb21223cb0ed0825f9c5e89e21 Cr-Commit-Position: refs/heads/master@{#25908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/es7/regress/regress-443982.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
6 years ago (2014-12-19 19:05:06 UTC) #2
arv (Not doing code reviews)
LGTM
6 years ago (2014-12-19 19:17:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820503005/1
6 years ago (2014-12-19 19:19:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 19:39:28 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-19 19:39:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f1329d960fcd8bb21223cb0ed0825f9c5e89e21
Cr-Commit-Position: refs/heads/master@{#25908}

Powered by Google App Engine
This is Rietveld 408576698