Issue 8205018: Gets component build to work with aura. As part of this I needed to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8205018: Gets component build to work with aura. As part of this I needed to (Closed)

Created:
9 years, 2 months ago by sky

Modified:
9 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Gets component build to work with aura. As part of this I needed to break screen_aura in two. Otherwise we end up with a circular dependency between ui and aura. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104662

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -53 lines)			Patch
M	ui/aura/aura.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura/desktop.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_delegate.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/aura/layout_manager.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	ui/aura/screen_aura.h	View	1 chunk	+40 lines, -0 lines	0 comments	Download
A +	ui/aura/screen_aura.cc	View	2 chunks	+17 lines, -26 lines	0 comments	Download
M	ui/aura/window_delegate.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/aura_shell/aura_shell.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura_shell/desktop_layout_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/shell.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/gfx/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/screen.h	View	2 chunks	+25 lines, -0 lines	1 comment	Download
M	ui/gfx/screen_aura.cc	View	2 chunks	+21 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 2 months ago (2011-10-08 00:57:32 UTC) #2

lgtm

http://codereview.chromium.org/8205018/diff/1/ui/gfx/screen.h
File ui/gfx/screen.h (right):

http://codereview.chromium.org/8205018/diff/1/ui/gfx/screen.h#newcode24
ui/gfx/screen.h:24: // old instant. This is used on aura to avoid circular
dependencies between ui
instance

Expand Messages | Collapse Messages