Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 820463004: Remove presubmit bot from 'git cl try'. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove presubmit bot from 'git cl try'. 'git cl try' is often executed before an lgtm was given - in this case the bot always fails. TBR=jochen@chromium.org NOTRY=true Committed: https://crrev.com/a23ef7d88bfaa1b3718cf4a94f459b093d209f19 Cr-Commit-Position: refs/heads/master@{#26182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
FYI
5 years, 11 months ago (2015-01-21 08:53:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820463004/1
5 years, 11 months ago (2015-01-21 08:55:00 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-21 08:55:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 08:56:17 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 08:56:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a23ef7d88bfaa1b3718cf4a94f459b093d209f19
Cr-Commit-Position: refs/heads/master@{#26182}

Powered by Google App Engine
This is Rietveld 408576698