Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 820433003: Enable smoothness.tough_pinch_zoom_cases on Chrome OS (Closed)

Created:
6 years ago by hashimoto
Modified:
5 years, 12 months ago
Reviewers:
nednguyen, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@powermonitor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable smoothness.tough_pinch_zoom_cases on Chrome OS Also, fix a bug in decorators.py where every element in |enabled_strings| except the first one is ignored. BUG=443981 TEST=tools/perf/run_benchmark --browser=cros-chrome --remote=${host} smoothness.tough_pinch_zoom_cases Committed: https://crrev.com/26e59874b04d1ecdf2e373c335d315f76352014d Cr-Commit-Position: refs/heads/master@{#309339}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -8 lines) Patch
M tools/perf/benchmarks/smoothness.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 1 chunk +5 lines, -6 lines 0 comments Download
A tools/telemetry/telemetry/decorators_unittest.py View 1 1 chunk +84 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (3 generated)
hashimoto
6 years ago (2014-12-19 12:19:15 UTC) #2
nednguyen
https://codereview.chromium.org/820433003/diff/1/tools/telemetry/telemetry/decorators.py File tools/telemetry/telemetry/decorators.py (left): https://codereview.chromium.org/820433003/diff/1/tools/telemetry/telemetry/decorators.py#oldcode133 tools/telemetry/telemetry/decorators.py:133: def ShouldSkip(test, possible_browser): Can you add unittest for this ...
6 years ago (2014-12-19 14:29:49 UTC) #3
hashimoto
https://codereview.chromium.org/820433003/diff/1/tools/telemetry/telemetry/decorators.py File tools/telemetry/telemetry/decorators.py (left): https://codereview.chromium.org/820433003/diff/1/tools/telemetry/telemetry/decorators.py#oldcode133 tools/telemetry/telemetry/decorators.py:133: def ShouldSkip(test, possible_browser): On 2014/12/19 14:29:48, nednguyen wrote: > ...
6 years ago (2014-12-19 17:14:46 UTC) #4
tonyg
https://codereview.chromium.org/820433003/diff/20001/tools/telemetry/telemetry/decorators_unittest.py File tools/telemetry/telemetry/decorators_unittest.py (right): https://codereview.chromium.org/820433003/diff/20001/tools/telemetry/telemetry/decorators_unittest.py#newcode1 tools/telemetry/telemetry/decorators_unittest.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years ago (2014-12-19 17:24:03 UTC) #6
nednguyen
LGTM https://codereview.chromium.org/820433003/diff/20001/tools/telemetry/telemetry/decorators_unittest.py File tools/telemetry/telemetry/decorators_unittest.py (right): https://codereview.chromium.org/820433003/diff/20001/tools/telemetry/telemetry/decorators_unittest.py#newcode1 tools/telemetry/telemetry/decorators_unittest.py:1: # Copyright 2014 The Chromium Authors. All rights ...
6 years ago (2014-12-20 01:18:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820433003/20001
6 years ago (2014-12-20 03:51:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-20 05:25:46 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/26e59874b04d1ecdf2e373c335d315f76352014d Cr-Commit-Position: refs/heads/master@{#309339}
6 years ago (2014-12-20 05:26:34 UTC) #11
nednguyen
On 2014/12/20 05:26:34, I haz the power (commit-bot) wrote: > Patchset 2 (id:??) landed as ...
6 years ago (2014-12-20 14:45:28 UTC) #12
hashimoto
On 2014/12/20 14:45:28, nednguyen wrote: > On 2014/12/20 05:26:34, I haz the power (commit-bot) wrote: ...
5 years, 12 months ago (2014-12-22 15:52:52 UTC) #13
nednguyen
5 years, 12 months ago (2014-12-22 16:05:21 UTC) #14
Message was sent while issue was closed.
On 2014/12/22 15:52:52, hashimoto (ooo - Jan.4) wrote:
> On 2014/12/20 14:45:28, nednguyen wrote:
> > On 2014/12/20 05:26:34, I haz the power (commit-bot) wrote:
> > > Patchset 2 (id:??) landed as
> > > https://crrev.com/26e59874b04d1ecdf2e373c335d315f76352014d
> > > Cr-Commit-Position: refs/heads/master@{#309339}
> > 
> > Hi Hashimoto, do you mind deleting some test cases in
> > unittest_util/run_tests_unittest that are already overlap with
> > decorator_unitttests?
> 
> Sorry, I'll be ooo until Jan. 5.
> It'd be appreciated if you could take care of it.
> If you are overloaded, let me remove them as soon as I get back to work.

I am overloaded, so removing them as soon as you get back to work sounds good to
me.

Powered by Google App Engine
This is Rietveld 408576698